Update jenkinsfile to run pact verification on PR as well #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmcts-jenkins-j-to-z
bot
added
ns:rpe
prd:rpe
rel:rpe-service-auth-provider-pr-862
labels
timja
reviewed
Nov 23, 2023
| @@ -41,9 +41,13 @@ withPipeline(type, product, component) { | |||
| disableLegacyDeployment() | |||
| syncBranchesWithMaster(branchesToSync) | |||
| expires(expiresAfter) | |||
|
|
|||
| onPR() { | |||
There was a problem hiding this comment.
Suggested change
| onPR() { | |
| onPR { |
timja
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is making it hard to test/diagnose what is currently causing pact-verification failures as it only runs on master branch
If you're adding a new secret then do the following
Run the script in
./bin/set-secret-in-all-vaults <microservice-name>and paste the output belowThis will ensure the secret is in all the vaults it needs to be
Does this PR introduce a breaking change? (check one with "x")