-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXUI-2039 - Ungrey back button #3807
Open
Josh-HMCTS
wants to merge
9
commits into
master
Choose a base branch
from
feature/exui-2039
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andywilkinshmcts
previously approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine, but do not merge until all the ungrey stuff is ready
RiteshHMCTS
previously approved these changes
Jul 22, 2024
09b0d97
Plan Result (aat)
Change Result (Click me) # module.redis6-cache.azurerm_redis_cache.redis will be updated in-place
~ resource "azurerm_redis_cache" "redis" {
id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/rpx-mc-redis6-cache-aat/providers/Microsoft.Cache/redis/xui-webapp-aat"
name = "xui-webapp-aat"
tags = {
"application" = "expert-ui"
"autoShutdown" = "true"
"builtFrom" = "https://github.com/HMCTS/rpx-xui-webapp.git"
"businessArea" = "CFT"
"contactSlackChannel" = "#xui-pipeline"
"environment" = "staging"
"managedBy" = "Expert UI"
}
# (21 unchanged attributes hidden)
~ redis_configuration {
~ maxfragmentationmemory_reserved = 1330 -> 642
~ maxmemory_delta = 1330 -> 642
~ maxmemory_reserved = 1330 -> 642
# (8 unchanged attributes hidden)
}
}
Plan: 0 to add, 1 to change, 0 to destroy. |
Plan Result (prod)
Change Result (Click me) # module.redis6-cache.azurerm_redis_cache.redis will be updated in-place
~ resource "azurerm_redis_cache" "redis" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/rpx-mc-redis6-cache-prod/providers/Microsoft.Cache/redis/xui-webapp-prod"
name = "xui-webapp-prod"
tags = {
"application" = "expert-ui"
"builtFrom" = "https://github.com/HMCTS/rpx-xui-webapp.git"
"businessArea" = "CFT"
"contactSlackChannel" = "#xui-pipeline"
"environment" = "production"
"managedBy" = "Expert UI"
}
# (21 unchanged attributes hidden)
~ redis_configuration {
~ maxfragmentationmemory_reserved = 1330 -> 642
~ maxmemory_delta = 1330 -> 642
~ maxmemory_reserved = 1330 -> 642
# (8 unchanged attributes hidden)
}
}
Plan: 0 to add, 1 to change, 0 to destroy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
aat/add-or-update
enable_keep_helm
enable_keep_helm
ns:xui
prd:xui
prod/add-or-update
rel:xui-webapp-pr-3807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-2039
https://tools.hmcts.net/jira/browse/EXUI-2074
https://tools.hmcts.net/jira/browse/EXUI-2038
Change description
Use-pre release version of toolkit with ungrey back button code