Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noc file change for sonar security #3799

Closed
wants to merge 50 commits into from

Conversation

OgunyemiO
Copy link
Contributor

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-152

Change description

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@OgunyemiO OgunyemiO added the enable_keep_helm enable_keep_helm label Jul 12, 2024
RiteshHMCTS
RiteshHMCTS previously approved these changes Jul 24, 2024
olusegz07
olusegz07 previously approved these changes Jul 24, 2024
Copy link
Contributor

@andywilkinshmcts andywilkinshmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your refactoring isn't functiionally equivalent, so unless you are confident that this doesn't matter (and have tests to prove it) it's probably not correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants