Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noc file change for sonar security #3799

Closed
wants to merge 50 commits into from
Closed

noc file change for sonar security #3799

wants to merge 50 commits into from

Conversation

OgunyemiO
Copy link
Contributor

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-152

Change description

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@OgunyemiO OgunyemiO added the enable_keep_helm enable_keep_helm label Jul 12, 2024
OgunyemiO and others added 28 commits July 12, 2024 12:25
@OgunyemiO
no-useless-escape comment
9e1d6de
@OgunyemiO
code reworked.
cbc7fc2
@OgunyemiO
build error fix
4545298
@OgunyemiO
lint error fix
0ecbe14
@OgunyemiO
unit test failure fix
24e9206
@OgunyemiO
Merge branch 'master' into EXUI-512-noc-sonar-security-LATEST
8cb23cb
@OgunyemiO
regex expression edited for Sonar
2ce6fc0
@OgunyemiO
changes to regex
d93e445
@OgunyemiO
Merge remote-tracking branch 'refs/remotes/origin/EXUI-512-noc-sonar-…
84241da 
…security-LATEST' into EXUI-512-noc-sonar-security-LATEST
@OgunyemiO
Merge branch 'master' into EXUI-512-noc-sonar-security-LATEST
1777bb6
@OgunyemiO
Merge branch 'master' into EXUI-512-noc-sonar-security-LATEST
6fa6852
@OgunyemiO
removeed unnecessary space
0980c29
@OgunyemiO
Merge remote-tracking branch 'refs/remotes/origin/EXUI-512-noc-sonar-…
7e7b322 
…security-LATEST' into EXUI-512-noc-sonar-security-LATEST
@OgunyemiO
regex adjust
489cc9b
@OgunyemiO
regex changed
89821fa
@OgunyemiO
Merge branch 'master' into EXUI-512-noc-sonar-security-LATEST
f8603ed
@OgunyemiO
postcode regex reworked
201efab
@OgunyemiO
Merge remote-tracking branch 'refs/remotes/origin/EXUI-512-noc-sonar-…
e2f8aac 
…security-LATEST' into EXUI-512-noc-sonar-security-LATEST
@OgunyemiO
slight adjustment to regex
a2f9ff4
@OgunyemiO
regex twick
e121cdb
@OgunyemiO
sonar fix
f6d0451
@OgunyemiO
replaced regex
d4067ab
@OgunyemiO
phonevalidator regex fix
1880c74
@OgunyemiO
tel regex
7910619
@OgunyemiO
comments removed
86e0891
@OgunyemiO
more fix
cfe302f
@OgunyemiO
sonar issue fix
b4d80d4
@OgunyemiO
Merge branch 'master' into EXUI-512-noc-sonar-security-LATEST
f6829c1
RiteshHMCTS
RiteshHMCTS previously approved these changes Jul 24, 2024
View reviewed changes
olusegz07
olusegz07 previously approved these changes Jul 24, 2024
View reviewed changes
andywilkinshmcts
andywilkinshmcts requested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@andywilkinshmcts andywilkinshmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your refactoring isn't functiionally equivalent, so unless you are confident that this doesn't matter (and have tests to prove it) it's probably not correct

src/noc/containers/noc-field/utils/noc-validators.ts Outdated Show resolved Hide resolved
src/noc/containers/noc-field/utils/noc-validators.ts Show resolved Hide resolved
src/noc/containers/noc-field/utils/noc-validators.ts Show resolved Hide resolved
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview August 7, 2024 08:56 Abandoned
@OgunyemiO OgunyemiO closed this Aug 21, 2024
@OgunyemiO OgunyemiO deleted the EXUI-512-noc-sonar-security-LATEST branch August 21, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andywilkinshmcts andywilkinshmcts andywilkinshmcts left review comments

@RiteshHMCTS RiteshHMCTS RiteshHMCTS left review comments

@olusegz07 olusegz07 olusegz07 left review comments

Assignees
No one assigned
Labels
enable_keep_helm enable_keep_helm ns:xui prd:xui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@OgunyemiO @andywilkinshmcts @RiteshHMCTS @olusegz07 @kasi-subramaniam