-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXUI 1851 #3790
EXUI 1851 #3790
Conversation
* EXUI-2018 - initial check in to stop user progressing when action required still selected. * EXUI-2018 - added in null checks. * EXUI-2018 - run yarn known issues. * removing comment as per peer review comments * EXUI-2018 - run yarn known issues. * EXUI-2018 - run yarn known issues.
* EXUI-2018 - run yarn known issues. * EXUI-2018 - run yarn known issues.
Plan Result (aat)
|
Plan Result (prod)
|
src/hearings/containers/request-hearing/hearing-edit-summary/hearing-edit-summary.component.ts
Outdated
Show resolved
Hide resolved
this.hearingRequestToCompareMainModel.hearingDetails.duration, | ||
this.hearingRequestMainModel.hearingDetails.duration | ||
); | ||
this.hearingLengthChanged = HearingsUtils.hasHearingDurationChagned(this.hearingRequestToCompareMainModel.hearingDetails.duration, this.hearingRequestMainModel.hearingDetails.duration); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same spelling mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved, thank you
...uest-hearing/hearing-edit-summary/hearing-timing-section/hearing-timing-section.component.ts
Outdated
Show resolved
Hide resolved
this.dateRangeStartChanged = HearingsUtils.hasDateChanged(this.hearingRequestMainModel.hearingDetails.hearingWindow.dateRangeStart, this.serviceHearingValuesModel.hearingWindow.dateRangeStart); | ||
this.dateRangeEndChanged = HearingsUtils.hasDateChanged(this.hearingRequestMainModel.hearingDetails.hearingWindow.dateRangeEnd, this.serviceHearingValuesModel.hearingWindow.dateRangeEnd); | ||
this.firstDateTimeMustBeChanged = HearingsUtils.hasDateChanged(this.hearingRequestMainModel.hearingDetails.hearingWindow.firstDateTimeMustBe, this.serviceHearingValuesModel.hearingWindow.firstDateTimeMustBe); | ||
this.durationChanged = HearingsUtils.hasHearingDurationChagned(this.hearingRequestMainModel.hearingDetails.duration, this.serviceHearingValuesModel.duration); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spelling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just need to fix the method name spelling issue!
9cc068b
to
880a1b9
Compare
Jira link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-1851
Change description
Fix to broken functional test plus enhancements to other areas in the timing section
Checklist