Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for caseworker names not appearing in task lists #3751

Merged

Conversation

connorpgpmcelroy
Copy link
Contributor

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-2027

Change description

Fix caseworker names not appearing on all tasks (not a problem on other task lists after testing)

Josh-HMCTS
Josh-HMCTS previously approved these changes Jun 25, 2024
Copy link
Contributor

@Josh-HMCTS Josh-HMCTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RiteshHMCTS
RiteshHMCTS previously approved these changes Jun 26, 2024
@hmcts-jenkins-j-to-z
Copy link
Contributor

Plan Result (aat)

⚠️ Resource Deletion will happen

This plan contains resource delete operation. Please check the plan result very carefully!

Plan: 0 to add, 1 to change, 1 to destroy.
  • Update
    • module.redis6-cache.azurerm_redis_cache.redis
  • Delete
    • azurerm_key_vault_secret.app_insights_connection_string
Change Result (Click me)
  # azurerm_key_vault_secret.app_insights_connection_string will be destroyed
  # (because azurerm_key_vault_secret.app_insights_connection_string is not in configuration)
  - resource "azurerm_key_vault_secret" "app_insights_connection_string" {
      - id                      = "https://rpx-aat.vault.azure.net/secrets/appinsights-connection-string-mc/2614e61a879b4789a81a54df6739a022" -> null
      - key_vault_id            = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/rpx-aat/providers/Microsoft.KeyVault/vaults/rpx-aat" -> null
      - name                    = "appinsights-connection-string-mc" -> null
      - resource_id             = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/rpx-aat/providers/Microsoft.KeyVault/vaults/rpx-aat/secrets/appinsights-connection-string-mc/versions/2614e61a879b4789a81a54df6739a022" -> null
      - resource_versionless_id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/rpx-aat/providers/Microsoft.KeyVault/vaults/rpx-aat/secrets/appinsights-connection-string-mc" -> null
      - tags                    = {} -> null
      - value                   = (sensitive value) -> null
      - version                 = "2614e61a879b4789a81a54df6739a022" -> null
      - versionless_id          = "https://rpx-aat.vault.azure.net/secrets/appinsights-connection-string-mc" -> null
    }

  # module.redis6-cache.azurerm_redis_cache.redis will be updated in-place
  ~ resource "azurerm_redis_cache" "redis" {
        id                            = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/rpx-mc-redis6-cache-aat/providers/Microsoft.Cache/redis/xui-webapp-aat"
        name                          = "xui-webapp-aat"
        tags                          = {
            "application"         = "expert-ui"
            "autoShutdown"        = "true"
            "builtFrom"           = "https://github.com/HMCTS/rpx-xui-webapp.git"
            "businessArea"        = "CFT"
            "contactSlackChannel" = "#xui-pipeline"
            "environment"         = "staging"
            "managedBy"           = "Expert UI"
        }
        # (21 unchanged attributes hidden)

      ~ redis_configuration {
          ~ maxfragmentationmemory_reserved         = 1330 -> 642
          ~ maxmemory_delta                         = 1330 -> 642
          ~ maxmemory_reserved                      = 1330 -> 642
            # (8 unchanged attributes hidden)
        }
    }

Plan: 0 to add, 1 to change, 1 to destroy.

Changes to Outputs:
  - appInsightsConnectionString   = (sensitive value) -> null

@hmcts-jenkins-j-to-z
Copy link
Contributor

Plan Result (prod)

Plan: 0 to add, 1 to change, 0 to destroy.
  • Update
    • module.redis6-cache.azurerm_redis_cache.redis
Change Result (Click me)
  # module.redis6-cache.azurerm_redis_cache.redis will be updated in-place
  ~ resource "azurerm_redis_cache" "redis" {
        id                            = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/rpx-mc-redis6-cache-prod/providers/Microsoft.Cache/redis/xui-webapp-prod"
        name                          = "xui-webapp-prod"
        tags                          = {
            "application"         = "expert-ui"
            "builtFrom"           = "https://github.com/HMCTS/rpx-xui-webapp.git"
            "businessArea"        = "CFT"
            "contactSlackChannel" = "#xui-pipeline"
            "environment"         = "production"
            "managedBy"           = "Expert UI"
        }
        # (21 unchanged attributes hidden)

      ~ redis_configuration {
          ~ maxfragmentationmemory_reserved         = 1330 -> 642
          ~ maxmemory_delta                         = 1330 -> 642
          ~ maxmemory_reserved                      = 1330 -> 642
            # (8 unchanged attributes hidden)
        }
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@RiteshHMCTS RiteshHMCTS changed the base branch from master to mc-srt-release-22-07-24 July 22, 2024 10:27
@RiteshHMCTS RiteshHMCTS merged commit 874e44c into mc-srt-release-22-07-24 Jul 22, 2024
@RiteshHMCTS RiteshHMCTS deleted the bug/EUI-2027-task-caseworker-names-missing branch July 22, 2024 10:28
RiteshHMCTS added a commit that referenced this pull request Jul 25, 2024
* Ex UI 1782 rework case role allocation screens to allow allocate to me (#3718)

* changes Reserve to me label to Allocate to me

* role category filtering removed from the choose-role component

* commented unrelated unit tests

* comment out unrelated unit tests

* yarn audit

* proposed fix for functional test failure

* yarn audit

* Unit tests fix based on PR review

* pipeline build failure fixes

---------

Co-authored-by: RiteshHMCTS <[email protected]>
Co-authored-by: Ritesh Dsouza <[email protected]>

* Add fix for caseworker names not appearing in task lists (#3751)

* Add fix for caseworker names not appearing in task lists

* Updating Terraform Formatting

* Update yarn-audit-known-issues

* Update yarn-audit-known-issues

---------

Co-authored-by: 54687 <61242337+hmcts-jenkins-j-to-z[bot]@users.noreply.github.com>
Co-authored-by: RiteshHMCTS <[email protected]>

* Bug/e UI 2028 tasks not being unassigned (#3794)

* Add the new pre-sign-in caseworker calls

* Fix lint issues

* Create caseWorkerUserDataCacheService.spec.ts

* Fix linting issues

* Attempt to fix functional tests

* Fix functional tests

* Update caseWorkerUserDataCacheService.ts

* Update caseWorkerUserDataCacheService.ts

---------

Co-authored-by: Andy Wilkins <[email protected]>
Co-authored-by: RiteshHMCTS <[email protected]>

* common lib version updated

* toolkit version updated

* toolkit version updated

---------

Co-authored-by: OgunyemiO <[email protected]>
Co-authored-by: connorpgpmcelroy <[email protected]>
Co-authored-by: 54687 <61242337+hmcts-jenkins-j-to-z[bot]@users.noreply.github.com>
Co-authored-by: Andy Wilkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants