Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ex UI 667 upgrade to node18 #211

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

codaimaster
Copy link

@codaimaster codaimaster commented Aug 17, 2023

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-667

Change description

Upgrade to Node-18

Does this PR introduce a breaking change? (check one with "x")

[X] Yes
[ ] No

@codaimaster codaimaster marked this pull request as draft August 17, 2023 21:16
@codaimaster codaimaster force-pushed the EXUI-667_upgrade_to_node18 branch 4 times, most recently from 81bd80a to 67faa99 Compare August 18, 2023 15:46
@olusegz07 olusegz07 changed the title Ex UI 667 upgrade to node18 fix: Ex UI 667 upgrade to node18 Oct 18, 2023
@hmcts hmcts deleted a comment from sonarcloud bot Oct 18, 2023
@olusegz07 olusegz07 force-pushed the EXUI-667_upgrade_to_node18 branch 2 times, most recently from f27f164 to b0fe2c1 Compare October 18, 2023 13:32
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@andywilkinshmcts andywilkinshmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments to be looked at

src/common/models/xuiNode.class.ts Show resolved Hide resolved
@@ -1,849 +0,0 @@
/* eslint-disable @typescript-eslint/no-empty-function */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this whole file has been deleted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants