Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed service messages references #1301

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

changed service messages references #1301

wants to merge 13 commits into from

Conversation

OgunyemiO
Copy link
Contributor

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-1079

Change description

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

RiteshHMCTS
RiteshHMCTS previously approved these changes Jul 5, 2024
View reviewed changes
Josh-HMCTS
Josh-HMCTS previously approved these changes Jul 5, 2024
View reviewed changes
@andywilkinshmcts
Copy link
Contributor

Needs updating to point to a final version of common lib, but ready for QA

Josh-HMCTS
Josh-HMCTS previously approved these changes Jul 24, 2024
View reviewed changes
connorpgpmcelroy
connorpgpmcelroy previously approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andywilkinshmcts
andywilkinshmcts previously approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@andywilkinshmcts andywilkinshmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that a full release of common lib is done before this is merged

Josh-HMCTS
Josh-HMCTS previously approved these changes Aug 6, 2024
View reviewed changes
Josh-HMCTS
Josh-HMCTS previously approved these changes Aug 6, 2024
View reviewed changes
RiteshHMCTS
RiteshHMCTS previously approved these changes Aug 6, 2024
View reviewed changes
@OgunyemiO OgunyemiO dismissed stale reviews from RiteshHMCTS and Josh-HMCTS via 584554a August 8, 2024 18:42
RiteshHMCTS
RiteshHMCTS previously approved these changes Aug 9, 2024
View reviewed changes
anthonydummer
anthonydummer previously approved these changes Aug 9, 2024
View reviewed changes
Copy link

@anthonydummer anthonydummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RiteshHMCTS
RiteshHMCTS reviewed Aug 30, 2024
View reviewed changes
.yarnrc.yml Outdated Show resolved Hide resolved
andywilkinshmcts
andywilkinshmcts approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@andywilkinshmcts andywilkinshmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that you release a new common lib full version and update this PR before this PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andywilkinshmcts andywilkinshmcts andywilkinshmcts approved these changes

@RiteshHMCTS RiteshHMCTS RiteshHMCTS approved these changes

@olusegz07 olusegz07 olusegz07 approved these changes

@StoneBenHMCTS StoneBenHMCTS StoneBenHMCTS approved these changes

@connorpgpmcelroy connorpgpmcelroy connorpgpmcelroy left review comments

@Josh-HMCTS Josh-HMCTS Josh-HMCTS left review comments

@anthonydummer anthonydummer anthonydummer left review comments

Assignees
No one assigned
Labels
enable_keep_helm ns:xui prd:xui rel:xui-mo-webapp-pr-1301
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@OgunyemiO @andywilkinshmcts @connorpgpmcelroy @RiteshHMCTS @Josh-HMCTS @olusegz07 @anthonydummer @StoneBenHMCTS