Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Google Tag Manager support #1266

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added Google Tag Manager support #1266

wants to merge 7 commits into from

Conversation

HYadavHMCTS
Copy link
Contributor

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-1228

Change description

Added Google tag manager implementation

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

andywilkinshmcts
andywilkinshmcts requested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@andywilkinshmcts andywilkinshmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong approach. We already have a service that does this. If it's not working we need to find out why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andywilkinshmcts andywilkinshmcts andywilkinshmcts requested changes

@RiteshHMCTS RiteshHMCTS RiteshHMCTS approved these changes

@OgunyemiO OgunyemiO OgunyemiO approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ns:xui prd:xui rel:xui-mo-webapp-pr-1266
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HYadavHMCTS @andywilkinshmcts @RiteshHMCTS @OgunyemiO