Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GovUK Frontend package update to version 4 #1242

Open
wants to merge 100 commits into
base: master
Choose a base branch
from

Conversation

HYadavHMCTS
Copy link
Contributor

@HYadavHMCTS HYadavHMCTS commented Jan 16, 2024

Jira link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-1219

Change description

Installed GovUk-Frontend 4.0.0 package
Updated rpx-xui-common-lib to version 2.0.9 for which a separate PR has been raised in common lib
repo hmcts/rpx-xui-common-lib#439

The updated common lib ver 2.0.9 includes fix for accordion top border issues in Selected Case component that was reflected on Unassigned and Assigned Cases page on Manage Organisation

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview January 26, 2024 11:06 Abandoned
RiteshHMCTS
RiteshHMCTS previously approved these changes Jan 26, 2024
olusegz07
olusegz07 previously approved these changes Jan 26, 2024
@HYadavHMCTS
Copy link
Contributor Author

Added json5 package to dependencies. Babel uses json5 internally. Had a brief chat with @shaed-parkar around it. Also AKS deploy step in the pipeline fails complaining it couldn't parse 'default.json' config. This should fix that issue

@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview January 26, 2024 12:38 Abandoned
RiteshHMCTS
RiteshHMCTS previously approved these changes Jan 26, 2024
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview January 29, 2024 09:35 Abandoned
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview January 29, 2024 10:50 Abandoned
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview January 30, 2024 15:11 Abandoned
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview January 31, 2024 15:49 Abandoned
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview January 31, 2024 16:34 Abandoned
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview January 31, 2024 17:45 Abandoned
@hmcts-jenkins-j-to-z hmcts-jenkins-j-to-z bot requested a deployment to preview January 31, 2024 19:40 Abandoned
@@ -79,7 +79,7 @@
"@hmcts/media-viewer": "2.10.1-RC.1",
"@hmcts/nodejs-healthcheck": "1.7.0",
"@hmcts/properties-volume": "0.0.13",
"@hmcts/rpx-xui-common-lib": "2.0.2",
"@hmcts/rpx-xui-common-lib": "2.0.8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated to latest from master, which is 2.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants