OGD invite user flow #1239
Open
OGD invite user flow #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgraded version
EXUI-803: Use ccpay-web-component's
EMUI-803: chart 2.4.18 is deprecated, upgraded to at least 3.0.0
fixtures for functional tests
Fix/ex UI 847 yarn audit file
…ithub.com/hmcts/rpx-xui-manage-organisations into EXUI-628_EXUI-634_upgrade-node18-and-ng15
andywilkinshmcts
requested changes
Mar 19, 2024
| let jurisdiction of jurisdictions.controls; | ||
| let i = index | ||
| "> | ||
| <!-- The jurisdiction name |
There was a problem hiding this comment.
I guess if it's commented out it can go
| @@ -70,6 +109,9 @@ export class UserDetailsComponent implements OnInit, OnDestroy { | |||
| } | |||
|
|
|||
| public ngOnDestroy(): void { | |||
| this.onDestory$.next(); | |||
There was a problem hiding this comment.
Please fix typo in "onDestroy$"
Probably not a functional issue, but it's bound to trip someone up in future
There was a problem hiding this comment.
Fixed spelling for 'onDestroy' in commit:
58d56cf
| @@ -72,7 +97,10 @@ export class UserRolesUtil { | |||
| * @param response - the response object from PRD. | |||
| */ | |||
| public static doesRoleDeletionExist(response) { | |||
| return response.roleDeletionResponse && AppUtils.propsExist(response, ['roleDeletionResponse']); | |||
| return ( | |||
| response.roleDeletionResponse && | |||
There was a problem hiding this comment.
I don't really mind if you don't revert it - I was just concerned that there are some strict whitespace rules in our tslint profile
|
|
||
| private onDestory$ = new Subject<void>(); |
There was a problem hiding this comment.
Typo in "Destory".
There was a problem hiding this comment.
Fixed spelling for 'onDestroy' in commit:
58d56cf
…on when coming from users page
… type default value
* update ogd guard to support refresh on new manage page * fix no changes on manage user page showing error page * resolve broken unit test * GA-101-Invite_UserFlow * mock update for retrive access types * Update yarn audit * test pipeline * Readd accessType call * Check pipeline * up puppeteer * update yarn lock * add refresh call to OGD endpoints * GA-125 GA-125 and GA-76 * Fix integration tests * GA-44 * yarn audit * Refactor UsersEffects to conditionally load data based on feature flag --------- Co-authored-by: Josh <[email protected]> Co-authored-by: Josh-HMCTS <[email protected]> Co-authored-by: poojithanag <[email protected]> Co-authored-by: sreekanthpuligadda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link (if applicable)
New OGD Invite User Flow
New OGD Edit User flow
Search filter for Users page
Change description