-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OGD invite user flow #1239
base: master
Are you sure you want to change the base?
OGD invite user flow #1239
Conversation
upgraded version
EXUI-803: Use ccpay-web-component's
EMUI-803: chart 2.4.18 is deprecated, upgraded to at least 3.0.0
fixtures for functional tests
Fix/ex UI 847 yarn audit file
…ithub.com/hmcts/rpx-xui-manage-organisations into EXUI-628_EXUI-634_upgrade-node18-and-ng15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small changes to make
let jurisdiction of jurisdictions.controls; | ||
let i = index | ||
"> | ||
<!-- The jurisdiction name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess if it's commented out it can go
@@ -70,6 +109,9 @@ export class UserDetailsComponent implements OnInit, OnDestroy { | |||
} | |||
|
|||
public ngOnDestroy(): void { | |||
this.onDestory$.next(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix typo in "onDestroy$"
Probably not a functional issue, but it's bound to trip someone up in future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed spelling for 'onDestroy' in commit:
58d56cf
@@ -72,7 +97,10 @@ export class UserRolesUtil { | |||
* @param response - the response object from PRD. | |||
*/ | |||
public static doesRoleDeletionExist(response) { | |||
return response.roleDeletionResponse && AppUtils.propsExist(response, ['roleDeletionResponse']); | |||
return ( | |||
response.roleDeletionResponse && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really mind if you don't revert it - I was just concerned that there are some strict whitespace rules in our tslint profile
|
||
private onDestory$ = new Subject<void>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in "Destory".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed spelling for 'onDestroy' in commit:
58d56cf
…on when coming from users page
… type default value
* update ogd guard to support refresh on new manage page * fix no changes on manage user page showing error page * resolve broken unit test * GA-101-Invite_UserFlow * mock update for retrive access types * Update yarn audit * test pipeline * Readd accessType call * Check pipeline * up puppeteer * update yarn lock * add refresh call to OGD endpoints * GA-125 GA-125 and GA-76 * Fix integration tests * GA-44 * yarn audit * Refactor UsersEffects to conditionally load data based on feature flag --------- Co-authored-by: Josh <[email protected]> Co-authored-by: Josh-HMCTS <[email protected]> Co-authored-by: poojithanag <[email protected]> Co-authored-by: sreekanthpuligadda <[email protected]>
Jira link (if applicable)
New OGD Invite User Flow
New OGD Edit User flow
Search filter for Users page
Change description