EUI-8430 MO accessibility issues from pa11y test

projects/gov-ui/src/lib/components/gov-uk-form-group-wrapper/gov-uk-form-group-wrapper.component.ts

@@ -1,4 +1,4 @@
-import {Component, Input} from '@angular/core';
+import { Component, Input } from '@angular/core';
 /*
 * Gov Uk Form Group Wrapper
 * Used to wrap group form elements in html tags below such as
@@ -24,9 +24,8 @@ import {Component, Input} from '@angular/core';
 })
 export class GovUkFormGroupWrapperComponent {
   constructor () {}
-  @Input() error: {isInvalid: boolean; messages: string}; // todo add interface
+  @Input() error: { isInvalid: boolean; messages: string }; // todo add interface
   @Input() group: string;
-  @Input() config: {hint: string; legend: string, key: string, isHeading: boolean;}; // TODO create a global interface
-
+  @Input() config: { hint: string; legend: string, key: string, isHeading: boolean; }; // TODO create a global interface
 }
 

projects/gov-ui/src/lib/util/helpers/html-templates.helper.ts

@@ -8,14 +8,10 @@ export class HtmlTemplatesHelper {
   * Sets described by string depending if
   * there is an error, error and hit or nothing
   * */
-  static setDescribedBy(errorMessage, config) {
-    if (!errorMessage) {
-      return config.hint ? `${config.id}-hint` : null;
-    } else if (errorMessage && errorMessage.isInvalid) {
-      return  config.hint ? `${config.id}-hint ${config.id}-error` : `${config.id}-error`;
-    } else {
-      return config.hint ? `${config.id}-hint` : null;
+  static setDescribedBy(errorMessage, config): string {
+    if (errorMessage?.isInvalid) {
+      return config.hint ? `${config.id}-hint ${config.id}-error` : `${config.id}-error`;
     }
-    return null;
+    return config.hint ? `${config.id}-hint` : null;
   }
 }

src/register/containers/hmcts-form-builder/src/lib/components/fieldset/fieldset.component.html

@@ -4,7 +4,8 @@
         <h2 class="govuk-heading-xl">
             {{item.legend.text}}
         </h2>
-    </legend>    
+    </legend>
+    <legend *ngIf="!item.legend"></legend>
     <app-jui-form-elements [validate]="validate" [group]="group" [data]="item"></app-jui-form-elements>
     <br>
   </ng-container>

src/register/containers/register/register.component.html

@@ -9,7 +9,7 @@ <h1 class="govuk-heading-xl">Register to manage civil, family, and tribunal law
           <a href="#"[routerLink]="'/register-org/register/organisation-name'" role="button" draggable="false" class="govuk-button govuk-!-margin-top-2 govuk-!-margin-bottom-8 govuk-button--start" data-module="govuk-button" aria-label="Start registering organisation">
             Start
             <svg class="govuk-button__start-icon" xmlns="http://www.w3.org/2000/svg" width="17.5" height="19" viewBox="0 0 33 40" role="presentation" focusable="false">
-              <path fill="currentColor" d="M0 0h13l20 20-20 20H0l20-20z" />
+              <path fill="currentColor" d="M0 0h13l20 20-20 20H0l20-20z" role="none" />
             </svg>
           </a>