Start date and end date added to Service Message Banner #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OgunyemiO
changed the title
connorpgpmcelroy
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
LGTM but have minor comment about import ordering, './' should be below '../../' as it is located closer to the file, that is general practice for the application and in the listing rules. There are a few places in these changes where this is incorrectly ordered
RiteshHMCTS
reviewed
Apr 25, 2024
projects/exui-common-lib/src/lib/components/service-messages/service-messages.component.spec.ts
Outdated
Show resolved
Hide resolved
RiteshHMCTS
approved these changes
Apr 25, 2024
olusegz07
approved these changes
Apr 25, 2024
…date-for-service-banners_NEW_LATEST' into EXUI-1079-start-enddate-for-service-banners_NEW_LATEST
RiteshHMCTS
approved these changes
Jul 24, 2024
Josh-HMCTS
deleted the
EXUI-1079-start-enddate-for-service-banners_NEW_LATEST
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tools.hmcts.net/jira/browse/EXUI-1079