Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXUI-249 TimoutNotificationService fix #397

Merged
merged 12 commits into from
Jul 5, 2023
Merged

EXUI-249 TimoutNotificationService fix #397

merged 12 commits into from
Jul 5, 2023

Conversation

bradley-hmcts
Copy link
Contributor

TimoutNotificationService fix

@bradley-hmcts bradley-hmcts changed the base branch from Release to master June 2, 2023 09:25
andywilkinshmcts
andywilkinshmcts approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@andywilkinshmcts andywilkinshmcts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably excessively cautious, but i would add subs = [] as well - can't guarantee that close won't be called more than once.

...ects/exui-common-lib/src/lib/services/timeout-notifications/timeout-notifications.service.ts
this.idle.watch();
}

public close(): void {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if this.subs was cleared too

@bradley-hmcts bradley-hmcts merged commit b282dd1 into master Jul 5, 2023
@bradley-hmcts bradley-hmcts deleted the EXUI-249 branch July 5, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dean-bullock dean-bullock dean-bullock approved these changes

@RiteshHMCTS RiteshHMCTS RiteshHMCTS approved these changes

@andywilkinshmcts andywilkinshmcts andywilkinshmcts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bradley-hmcts @andywilkinshmcts @RiteshHMCTS @dean-bullock