Update dependency urllib3 to v1.26.18 [SECURITY]

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
urllib3 (changelog)	==1.25.11 -> ==1.26.18

GitHub Vulnerability Alerts

CVE-2021-33503

Impact

When provided with a URL containing many @ characters in the authority component the authority regular expression exhibits catastrophic backtracking causing a denial of service if a URL were passed as a parameter or redirected to via an HTTP redirect.

Patches

The issue has been fixed in urllib3 v1.26.5.

References

• CVE-2021-33503
• JVNVU#92413403 (English)
• JVNVU#92413403 (Japanese)
• urllib3 v1.26.5

For more information

If you have any questions or comments about this advisory:

• Ask in our community Discord
• Email [email protected]

CVE-2023-43804

urllib3 doesn't treat the Cookie HTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify a Cookie header and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly.

Users must handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the Cookie header, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach.

Affected usages

We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:

• Using an affected version of urllib3 (patched in v1.26.17 and v2.0.6)
• Using the Cookie header on requests, which is mostly typical for impersonating a browser.
• Not disabling HTTP redirects
• Either not using HTTPS or for the origin server to redirect to a malicious origin.

Remediation

• Upgrading to at least urllib3 v1.26.17 or v2.0.6
• Disabling HTTP redirects using redirects=False when sending requests.
• Not using the Cookie header.

CVE-2023-45803

urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like POST) to GET as is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.

From RFC 9110 Section 9.3.1:

A client SHOULD NOT generate content in a GET request unless it is made directly to an origin server that has previously indicated, in or out of band, that such a request has a purpose and will be adequately supported.

Affected usages

Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.

Both of the following conditions must be true to be affected by this vulnerability:

• If you're using urllib3 and submitting sensitive information in the HTTP request body (such as form data or JSON)
• The origin service is compromised and starts redirecting using 303 to a malicious peer or the redirected-to service becomes compromised.

Remediation

You can remediate this vulnerability with any of the following steps:

• Upgrade to a patched version of urllib3 (v1.26.18 or v2.0.7)
• Disable redirects for services that you aren't expecting to respond with redirects with redirects=False.
• Disable automatic redirects with redirects=False and handle 303 redirects manually by stripping the HTTP request body.

---

Release Notes

urllib3/urllib3 (urllib3)

v1.26.18

Compare Source

====================

• Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses.

v1.26.17

Compare Source

====================

• Added the Cookie header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via Retry.remove_headers_on_redirect. (#&#8203;3139 <https://github.com/urllib3/urllib3/pull/3139>_)

v1.26.16

Compare Source

====================

• Fixed thread-safety issue where accessing a PoolManager with many distinct origins
  would cause connection pools to be closed while requests are in progress (#&#8203;2954 <https://github.com/urllib3/urllib3/pull/2954>_)

v1.26.15

Compare Source

====================

• Fix socket timeout value when HTTPConnection is reused (#&#8203;2645 <https://github.com/urllib3/urllib3/issues/2645>__)
• Remove "!" character from the unreserved characters in IPv6 Zone ID parsing
  (#&#8203;2899 <https://github.com/urllib3/urllib3/issues/2899>__)
• Fix IDNA handling of '\x80' byte (#&#8203;2901 <https://github.com/urllib3/urllib3/issues/2901>__)

v1.26.14

Compare Source

====================

• Fixed parsing of port 0 (zero) returning None, instead of 0. (#&#8203;2850 <https://github.com/urllib3/urllib3/issues/2850>__)
• Removed deprecated getheaders() calls in contrib module. Fixed the type hint of PoolKey.key_retries by adding bool to the union. (#&#8203;2865 <https://github.com/urllib3/urllib3/issues/2865>__)

v1.26.13

Compare Source

====================

• Deprecated the HTTPResponse.getheaders() and HTTPResponse.getheader() methods.
• Fixed an issue where parsing a URL with leading zeroes in the port would be rejected
  even when the port number after removing the zeroes was valid.
• Fixed a deprecation warning when using cryptography v39.0.0.
• Removed the <4 in the Requires-Python packaging metadata field.

v1.26.12

Compare Source

====================

• Deprecated the urllib3[secure] extra and the urllib3.contrib.pyopenssl module.
  Both will be removed in v2.x. See this GitHub issue <https://github.com/urllib3/urllib3/issues/2680>_
  for justification and info on how to migrate.

v1.26.11

Compare Source

====================

• Fixed an issue where reading more than 2 GiB in a call to HTTPResponse.read would
  raise an OverflowError on Python 3.9 and earlier.

v1.26.10

Compare Source

====================

• Removed support for Python 3.5
• Fixed an issue where a ProxyError recommending configuring the proxy as HTTP
  instead of HTTPS could appear even when an HTTPS proxy wasn't configured.

v1.26.9

Compare Source

===================

• Changed urllib3[brotli] extra to favor installing Brotli libraries that are still
  receiving updates like brotli and brotlicffi instead of brotlipy.
  This change does not impact behavior of urllib3, only which dependencies are installed.
• Fixed a socket leaking when HTTPSConnection.connect() raises an exception.
• Fixed server_hostname being forwarded from PoolManager to HTTPConnectionPool
  when requesting an HTTP URL. Should only be forwarded when requesting an HTTPS URL.

v1.26.8

Compare Source

===================

• Added extra message to urllib3.exceptions.ProxyError when urllib3 detects that
  a proxy is configured to use HTTPS but the proxy itself appears to only use HTTP.
• Added a mention of the size of the connection pool when discarding a connection due to the pool being full.
• Added explicit support for Python 3.11.
• Deprecated the Retry.MAX_BACKOFF class property in favor of Retry.DEFAULT_MAX_BACKOFF
  to better match the rest of the default parameter names. Retry.MAX_BACKOFF is removed in v2.0.
• Changed location of the vendored ssl.match_hostname function from urllib3.packages.ssl_match_hostname
  to urllib3.util.ssl_match_hostname to ensure Python 3.10+ compatibility after being repackaged
  by downstream distributors.
• Fixed absolute imports, all imports are now relative.

v1.26.7

Compare Source

===================

• Fixed a bug with HTTPS hostname verification involving IP addresses and lack
  of SNI. (Issue #​2400)
• Fixed a bug where IPv6 braces weren't stripped during certificate hostname
  matching. (Issue #​2240)

v1.26.6

Compare Source

===================

• Deprecated the urllib3.contrib.ntlmpool module. urllib3 is not able to support
  it properly due to reasons listed in this issue <https://github.com/urllib3/urllib3/issues/2282>_.
  If you are a user of this module please leave a comment.
• Changed HTTPConnection.request_chunked() to not erroneously emit multiple
  Transfer-Encoding headers in the case that one is already specified.
• Fixed typo in deprecation message to recommend Retry.DEFAULT_ALLOWED_METHODS.

v1.26.5

Compare Source

===================

• Fixed deprecation warnings emitted in Python 3.10.
• Updated vendored six library to 1.16.0.
• Improved performance of URL parser when splitting
  the authority component.

v1.26.4

Compare Source

===================

• Changed behavior of the default SSLContext when connecting to HTTPS proxy
  during HTTPS requests. The default SSLContext now sets check_hostname=True.

v1.26.3

Compare Source

===================

• Fixed bytes and string comparison issue with headers (Pull #​2141)

• Changed ProxySchemeUnknown error message to be
  more actionable if the user supplies a proxy URL without
  a scheme. (Pull #​2107)

v1.26.2

Compare Source

===================

• Fixed an issue where wrap_socket and CERT_REQUIRED wouldn't
  be imported properly on Python 2.7.8 and earlier (Pull #​2052)

v1.26.1

Compare Source

====================

• Fixed thread-safety issue where accessing a PoolManager with many distinct origins
  would cause connection pools to be closed while requests are in progress (#&#8203;2954 <https://github.com/urllib3/urllib3/pull/2954>_)

v1.26.0

Compare Source

===================

• NOTE: urllib3 v2.0 will drop support for Python 2.
  Read more in the v2.0 Roadmap <https://urllib3.readthedocs.io/en/latest/v2-roadmap.html>_.

• Added support for HTTPS proxies contacting HTTPS servers (Pull #​1923, Pull #​1806)

• Deprecated negotiating TLSv1 and TLSv1.1 by default. Users that
  still wish to use TLS earlier than 1.2 without a deprecation warning
  should opt-in explicitly by setting ssl_version=ssl.PROTOCOL_TLSv1_1 (Pull #​2002)
  Starting in urllib3 v2.0: Connections that receive a DeprecationWarning will fail

• Deprecated Retry options Retry.DEFAULT_METHOD_WHITELIST, Retry.DEFAULT_REDIRECT_HEADERS_BLACKLIST
  and Retry(method_whitelist=...) in favor of Retry.DEFAULT_ALLOWED_METHODS,
  Retry.DEFAULT_REMOVE_HEADERS_ON_REDIRECT, and Retry(allowed_methods=...)
  (Pull #​2000) Starting in urllib3 v2.0: Deprecated options will be removed

• Added default User-Agent header to every request (Pull #​1750)

• Added urllib3.util.SKIP_HEADER for skipping User-Agent, Accept-Encoding,
  and Host headers from being automatically emitted with requests (Pull #​2018)

• Collapse transfer-encoding: chunked request data and framing into
  the same socket.send() call (Pull #​1906)

• Send http/1.1 ALPN identifier with every TLS handshake by default (Pull #​1894)

• Properly terminate SecureTransport connections when CA verification fails (Pull #​1977)

• Don't emit an SNIMissingWarning when passing server_hostname=None
  to SecureTransport (Pull #​1903)

• Disabled requesting TLSv1.2 session tickets as they weren't being used by urllib3 (Pull #​1970)

• Suppress BrokenPipeError when writing request body after the server
  has closed the socket (Pull #​1524)

• Wrap ssl.SSLError that can be raised from reading a socket (e.g. "bad MAC")
  into an urllib3.exceptions.SSLError (Pull #​1939)

---

Configuration

📅 Schedule: Branch creation - "" in timezone Europe/London, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Mend Renovate. View repository job log here.

[renovate]

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (==1.26.18). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.