Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dfpl 2111 2334 demo #5491

Closed
wants to merge 71 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
842ea7a
DFPL-1847: Initial changes
DanCatchpole Nov 10, 2023
4806321
DFPL-1847: Add tests to ensure that the WA field is set + cleaned up
DanCatchpole Nov 13, 2023
e914726
Merge branch 'master' into DFPL-1847
so99y Nov 14, 2023
96d6870
flip equals
DanCatchpole Nov 14, 2023
8acc525
Merge remote-tracking branch 'origin/DFPL-1847' into DFPL-1847
DanCatchpole Nov 14, 2023
e045ab7
Merge branch 'master' into DFPL-1847
DanCatchpole Dec 12, 2023
d6eb406
Merge branch 'master' into DFPL-1847
DanCatchpole Dec 13, 2023
40bec5c
Merge branch 'master' into DFPL-1847
DanCatchpole Dec 13, 2023
880bf14
Merge branch 'master' into DFPL-1847
so99y Mar 15, 2024
cec1dce
Missing permissions
Mar 15, 2024
f38d095
Merge branch 'master' into DFPL-1847
AlistairEdwinOsborne Apr 2, 2024
a70d13c
Merge branch 'master' into DFPL-1847
DanCatchpole Apr 25, 2024
ccad38e
fix missing import issue
DanCatchpole Apr 25, 2024
4b0930e
fix test after spring upgrade
DanCatchpole Apr 25, 2024
4b9c031
Merge branch 'master' into DFPL-1847
DanCatchpole Apr 30, 2024
1f523fa
Merge branch 'master' into DFPL-1847
DanCatchpole May 14, 2024
2b8710d
DFPL-2111: Replace WA task with chasing email cron job for CMOs
AlistairEdwinOsborne May 15, 2024
961f2fc
Merge branch 'master' into DFPL-2111
AlistairEdwinOsborne May 15, 2024
77bdd0b
add tests for email job
AlistairEdwinOsborne May 16, 2024
b63acc2
checkstyle
AlistairEdwinOsborne May 17, 2024
6a10c52
Merge branch 'master' into DFPL-2111
AlistairEdwinOsborne May 17, 2024
73f6e12
remove old job and tests
AlistairEdwinOsborne May 17, 2024
65ccb7e
checkstyle 2
AlistairEdwinOsborne May 17, 2024
04e4822
add feature toggle
chak-shing-lo-justice May 29, 2024
c05d4d9
fix test
chak-shing-lo-justice May 29, 2024
f1bfb13
fix unit test
chak-shing-lo-justice May 30, 2024
0d2fc33
Merge branch 'master' into DFPL-2334
chak-shing-lo-justice May 30, 2024
0c391b7
fix code style
chak-shing-lo-justice May 30, 2024
97b1728
Merge branch 'DFPL-2334' of https://github.com/hmcts/fpl-ccd-configur…
chak-shing-lo-justice May 30, 2024
363605e
fix ReplyToMessageJudgeControllerSubmittedTest
chak-shing-lo-justice May 30, 2024
56e4e20
fix code check
chak-shing-lo-justice May 30, 2024
8a015b5
CTSC should always get noti
chak-shing-lo-justice Jun 10, 2024
eaeceb0
fix EmailTemplateTest bean not found
chak-shing-lo-justice Jun 10, 2024
b7ff8b2
fix bean not found
chak-shing-lo-justice Jun 10, 2024
4d82360
fix mock
chak-shing-lo-justice Jun 10, 2024
e445293
Merge branch 'master' into DFPL-2111
AlistairEdwinOsborne Jun 10, 2024
9e80546
Merge branch 'master' into DFPL-2334
DanCatchpole Jun 11, 2024
0b3ad38
change to run in the middle of the day for testing
AlistairEdwinOsborne Jun 11, 2024
0c9b5cc
Merge remote-tracking branch 'origin/DFPL-2111' into DFPL-2111
AlistairEdwinOsborne Jun 11, 2024
9b1b213
Merge branch 'master' into DFPL-2111
AlistairEdwinOsborne Jun 14, 2024
c3f1470
remove permission from authorisationcaseevent
AlistairEdwinOsborne Jun 14, 2024
52a5e05
Merge branch 'master' into DFPL-2111
AlistairEdwinOsborne Jun 17, 2024
1153de1
Merge branch 'master' into DFPL-2111
AlistairEdwinOsborne Jun 17, 2024
8d820ad
Merge branch 'master' into DFPL-2111
Braimah101 Jun 18, 2024
54de662
set to run at 7:30 for testing
AlistairEdwinOsborne Jun 19, 2024
6c43419
Merge branch 'master' into DFPL-2111
AlistairEdwinOsborne Jun 20, 2024
f2c3fad
set to run at 11 for testing
AlistairEdwinOsborne Jun 20, 2024
057f3f3
Merge remote-tracking branch 'origin/DFPL-2111' into DFPL-2111
AlistairEdwinOsborne Jun 20, 2024
7885fd7
set to run at 12 for testing
AlistairEdwinOsborne Jun 20, 2024
eb99f44
Merge branch 'master' into DFPL-2111
AlistairEdwinOsborne Jun 24, 2024
3a257c9
Merge branch 'master' into DFPL-2111
DanCatchpole Jul 8, 2024
0355baa
Merge branch 'master' into DFPL-2334
DanCatchpole Jul 8, 2024
8bd91c7
Merge branch 'DFPL-2334' into DFPL-2111-2334-demo
DanCatchpole Jul 8, 2024
38be934
add published court field to events
DanCatchpole Jul 9, 2024
aaa7765
remove async tag from event handler method
AlistairEdwinOsborne Jul 9, 2024
58988ee
Merge branch 'master' into DFPL-2111-2334-demo
AlistairEdwinOsborne Jul 10, 2024
c868e0a
checkstyle
AlistairEdwinOsborne Jul 10, 2024
f5cf669
Merge branch 'DFPL-2334' into DFPL-2111-2334-demo
DanCatchpole Jul 10, 2024
09238f1
Merge branch 'DFPL-2111-2334-demo' of github.com:hmcts/fpl-ccd-config…
DanCatchpole Jul 10, 2024
0ecee3f
add toggling for draft order uploaded event
chak-shing-lo-justice Jul 10, 2024
4da2082
Merge branch 'master' into DFPL-2334
chak-shing-lo-justice Jul 10, 2024
3fcc0e3
update UploadDraftOrdersSubmittedControllerTest
chak-shing-lo-justice Jul 10, 2024
5218b58
Merge branch 'DFPL-2334' into DFPL-2111-2334-demo
DanCatchpole Jul 11, 2024
8329c57
Merge branch 'master' into DFPL-1847
DanCatchpole Jul 15, 2024
545becf
remove code
DanCatchpole Jul 15, 2024
40634f1
missing comma
DanCatchpole Jul 15, 2024
eddeaa5
merge DFPL-1847 into demo
DanCatchpole Jul 15, 2024
81bef9e
test
DanCatchpole Jul 15, 2024
226ef30
log
DanCatchpole Jul 15, 2024
060b2b5
test uncapitalize
DanCatchpole Jul 15, 2024
8a02ad1
test uncapitalize
DanCatchpole Jul 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1691,18 +1691,5 @@
"CRUD": "CR"
}
]
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"CaseEventID": "sendOrderReminder",
"AccessControl": [
{
"UserRoles": [
"caseworker-publiclaw-courtadmin"
],
"CRUD": "CR"
}
]
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -2106,6 +2106,13 @@
"UserRole": "[EPSMANAGING]",
"CRUD": "CRUD"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"CaseFieldID": "draftOrderNeedsReviewUploaded",
"UserRole": "[EPSMANAGING]",
"CRUD": "CRU"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1490,6 +1490,13 @@
"UserRole": "[LABARRISTER]",
"CRUD": "CRU"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"CaseFieldID": "draftOrderNeedsReviewUploaded",
"UserRole": "[LABARRISTER]",
"CRUD": "CRU"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2099,6 +2099,13 @@
"UserRole": "[LAMANAGING]",
"CRUD": "CRUD"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"CaseFieldID": "draftOrderNeedsReviewUploaded",
"UserRole": "[LAMANAGING]",
"CRUD": "CRU"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2167,6 +2167,13 @@
"UserRole": "[LASHARED]",
"CRUD": "CRUD"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"CaseFieldID": "draftOrderNeedsReviewUploaded",
"UserRole": "[LASHARED]",
"CRUD": "CRU"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3213,6 +3213,13 @@
"UserRole": "[LASOLICITOR]",
"CRUD": "CRUD"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"CaseFieldID": "draftOrderNeedsReviewUploaded",
"UserRole": "[LASOLICITOR]",
"CRUD": "CRU"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1826,6 +1826,13 @@
"UserRole": "caseworker-publiclaw-systemupdate",
"CRUD": "CRU"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"CaseFieldID": "draftOrderNeedsReviewUploaded",
"UserRole": "caseworker-publiclaw-systemupdate",
"CRUD": "CRU"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
Expand Down
17 changes: 17 additions & 0 deletions ccd-definition/CaseEvent/CareSupervision/DEPRECATED.json
Original file line number Diff line number Diff line change
Expand Up @@ -366,5 +366,22 @@
"ShowSummary": "N",
"ShowEventNotes": "Y",
"EndButtonLabel": "Submit"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"ID": "sendOrderReminder",
"Name": "Send order reminder",
"Description": "Lets the CTSC send a reminder to the LA to upload an order.",
"DisplayOrder": 22,
"PreConditionState(s)": "PREPARE_FOR_HEARING;FINAL_HEARING;",
"PostConditionState": "*",
"SecurityClassification": "Public",
"CallBackURLAboutToStartEvent": "${CCD_DEF_CASE_SERVICE_BASE_URL}/callback/send-order-reminder/about-to-start",
"CallBackURLSubmittedEvent": "${CCD_DEF_CASE_SERVICE_BASE_URL}/callback/send-order-reminder/submitted",
"ShowSummary": "N",
"ShowEventNotes": "N",
"Publish": "Y",
"EndButtonLabel": "Send reminder"
}
]
17 changes: 0 additions & 17 deletions ccd-definition/CaseEvent/CareSupervision/MultiState.json
Original file line number Diff line number Diff line change
Expand Up @@ -1052,23 +1052,6 @@
"ShowEventNotes": "N",
"EndButtonLabel": "Done"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"ID": "sendOrderReminder",
"Name": "Send order reminder",
"Description": "Lets the CTSC send a reminder to the LA to upload an order.",
"DisplayOrder": 31,
"PreConditionState(s)": "PREPARE_FOR_HEARING;FINAL_HEARING;",
"PostConditionState": "*",
"SecurityClassification": "Public",
"CallBackURLAboutToStartEvent": "${CCD_DEF_CASE_SERVICE_BASE_URL}/callback/send-order-reminder/about-to-start",
"CallBackURLSubmittedEvent": "${CCD_DEF_CASE_SERVICE_BASE_URL}/callback/send-order-reminder/submitted",
"ShowSummary": "N",
"ShowEventNotes": "N",
"Publish": "Y",
"EndButtonLabel": "Send reminder"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,5 +105,18 @@
"PageDisplayOrder": 3,
"Publish": "Y",
"FieldShowCondition": "isMessageRegardingAdditionalApplications=\"DO_NOT_SHOW\""
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"CaseEventID": "messageJudgeOrLegalAdviser",
"CaseFieldID": "court",
"PageFieldDisplayOrder": 100,
"DisplayContext": "READONLY",
"PageID": "NewMessageNote",
"PageDisplayOrder": 3,
"PageColumnNumber": 1,
"Publish": "Y",
"FieldShowCondition": "isMessageRegardingAdditionalApplications=\"DO_NOT_SHOW\""
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -83,5 +83,18 @@
"ShowSummaryChangeOption": "N",
"Publish": "Y",
"FieldShowCondition": "judicialMessageReply=\"DO_NOT_SHOW\""
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"CaseEventID": "replyToMessageJudgeOrLegalAdviser",
"CaseFieldID": "court",
"PageFieldDisplayOrder": 100,
"DisplayContext": "READONLY",
"PageID": "ReplyToMessage",
"PageDisplayOrder": 2,
"PageColumnNumber": 1,
"Publish": "Y",
"FieldShowCondition": "judicialMessageReply=\"DO_NOT_SHOW\""
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,19 @@
"ShowSummaryChangeOption": "N",
"CallBackURLMidEvent": "${CCD_DEF_CASE_SERVICE_BASE_URL}/callback/upload-additional-applications/initial-choice/mid-event"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"CaseEventID": "uploadAdditionalApplications",
"CaseFieldID": "court",
"PageFieldDisplayOrder": 100,
"DisplayContext": "READONLY",
"PageID": 1,
"PageDisplayOrder": 1,
"PageColumnNumber": 1,
"Publish": "Y",
"FieldShowCondition": "additionalApplicationsLabel=\"DO_NOT_SHOW\""
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
Expand Down
27 changes: 27 additions & 0 deletions ccd-definition/CaseEventToFields/CareSupervision/uploadCMO.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,33 @@
"ShowSummaryChangeOption": "N",
"CallBackURLMidEvent": "${CCD_DEF_CASE_SERVICE_BASE_URL}/callback/upload-draft-orders/populate-initial-data/mid-event"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"CaseEventID": "uploadCMO",
"CaseFieldID": "court",
"PageID": "OrderDraftKindSelection",
"PageFieldDisplayOrder": 100,
"PageColumnNumber": 1,
"PageDisplayOrder": 1,
"DisplayContext": "READONLY",
"FieldShowCondition": "hearingOrderDraftKind=\"DO_NOT_SHOW\"",
"Publish": "Y"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"CaseEventID": "uploadCMO",
"CaseFieldID": "draftOrderNeedsReviewUploaded",
"PageID": "OrderDraftKindSelection",
"DisplayContext": "MANDATORY",
"PageFieldDisplayOrder": 101,
"PageDisplayOrder": 1,
"PageColumnNumber": 1,
"ShowSummaryChangeOption": "N",
"FieldShowCondition": "hearingOrderDraftKind=\"DO_NOT_SHOW\"",
"Publish": "Y"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,14 @@
"Label": "Last created work allocation task",
"SecurityClassification": "Public",
"Searchable": "N"
},
{
"LiveFrom": "01/01/2017",
"CaseTypeID": "CARE_SUPERVISION_EPO",
"ID": "draftOrderNeedsReviewUploaded",
"FieldType": "YesOrNo",
"Label": "Last upload draft order event resulted in a review order task",
"SecurityClassification": "Public",
"Searchable": "N"
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import uk.gov.hmcts.reform.fpl.model.RespondentParty;
import uk.gov.hmcts.reform.fpl.model.judicialmessage.JudicialMessage;
import uk.gov.hmcts.reform.fpl.model.summary.SyntheticCaseSummary;
import uk.gov.hmcts.reform.fpl.service.FeatureToggleService;
import uk.gov.hmcts.reform.fpl.service.ccd.CCDConcurrencyHelper;
import uk.gov.service.notify.NotificationClient;
import uk.gov.service.notify.NotificationClientException;
Expand Down Expand Up @@ -44,6 +45,9 @@ class MessageJudgeControllerSubmittedTest extends AbstractCallbackTest {
@MockBean
private CCDConcurrencyHelper concurrencyHelper;

@MockBean
private FeatureToggleService featureToggleService;

MessageJudgeControllerSubmittedTest() {
super("message-judge");
}
Expand Down Expand Up @@ -87,6 +91,7 @@ void shouldNotifyJudicialMessageRecipientWhenNewJudicialMessageAdded() throws No
.build())))
.build();

when(featureToggleService.isCourtNotificationEnabledForWa(any())).thenReturn(true);
when(concurrencyHelper.startEvent(any(), any(String.class))).thenAnswer(i -> StartEventResponse.builder()
.caseDetails(asCaseDetails(caseData))
.eventId(i.getArgument(1))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import uk.gov.hmcts.reform.fpl.model.Respondent;
import uk.gov.hmcts.reform.fpl.model.RespondentParty;
import uk.gov.hmcts.reform.fpl.model.judicialmessage.JudicialMessage;
import uk.gov.hmcts.reform.fpl.service.FeatureToggleService;
import uk.gov.hmcts.reform.fpl.service.ccd.CCDConcurrencyHelper;
import uk.gov.service.notify.NotificationClient;
import uk.gov.service.notify.NotificationClientException;
Expand All @@ -18,8 +19,10 @@
import java.util.Map;
import java.util.UUID;

import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoInteractions;
import static org.mockito.Mockito.when;
import static uk.gov.hmcts.reform.fpl.Constants.LOCAL_AUTHORITY_1_CODE;
import static uk.gov.hmcts.reform.fpl.NotifyTemplates.JUDICIAL_MESSAGE_REPLY_TEMPLATE;
import static uk.gov.hmcts.reform.fpl.enums.JudicialMessageStatus.CLOSED;
Expand All @@ -42,6 +45,9 @@ class ReplyToMessageJudgeControllerSubmittedTest extends AbstractCallbackTest {
@MockBean
private CCDConcurrencyHelper concurrencyHelper;

@MockBean
private FeatureToggleService featureToggleService;

ReplyToMessageJudgeControllerSubmittedTest() {
super("reply-message-judge");
}
Expand Down Expand Up @@ -85,6 +91,8 @@ void shouldNotifyJudicialMessageRecipientWhenJudicialMessageReplyAdded() throws
.build())))
.build();

when(featureToggleService.isCourtNotificationEnabledForWa(any())).thenReturn(true);

postSubmittedEvent(asCaseDetails(caseData));

Map<String, Object> expectedData = Map.of(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import uk.gov.hmcts.reform.fpl.model.common.Element;
import uk.gov.hmcts.reform.fpl.model.common.OtherApplicationsBundle;
import uk.gov.hmcts.reform.fpl.service.DocumentDownloadService;
import uk.gov.hmcts.reform.fpl.service.FeatureToggleService;
import uk.gov.hmcts.reform.fpl.service.SendDocumentService;
import uk.gov.hmcts.reform.fpl.service.UploadDocumentService;
import uk.gov.hmcts.reform.fpl.service.additionalapplications.UploadAdditionalApplicationsService;
Expand Down Expand Up @@ -143,6 +144,8 @@ class UploadAdditionalApplicationsSubmittedControllerTest extends AbstractCallba
private CafcassNotificationService cafcassNotificationService;
@MockBean
private SendDocumentService sendDocumentService;
@MockBean
private FeatureToggleService featureToggleService;
@Captor
private ArgumentCaptor<Function<CaseDetails, Map<String, Object>>> changeFunctionCaptor;

Expand Down Expand Up @@ -213,6 +216,7 @@ void init() {

doNothing().when(sendDocumentService).sendDocuments(any());
doNothing().when(cafcassNotificationService).sendEmail(any(), any(), any());
when(featureToggleService.isCourtNotificationEnabledForWa(any())).thenReturn(true);
}


Expand Down
Loading
Loading