Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFPL-1710: am-role-assignment-service pact tests #5358

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions service/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,7 @@ dependencies {
contractTestImplementation group: 'org.junit.jupiter', name: 'junit-jupiter-api', version: versions.junit_jupiter
contractTestRuntimeOnly group: 'org.junit.platform', name: 'junit-platform-commons', version: '1.8.2'
contractTestImplementation group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.13.5'
contractTestImplementation group: 'com.fasterxml.jackson.datatype', name: 'jackson-datatype-jsr310', version: '2.13.5'
contractTestImplementation group: 'org.springframework.cloud', name: 'spring-cloud-starter-openfeign', version: '4.1.1'
contractTestImplementation group: 'org.springframework.cloud', name: 'spring-cloud-netflix-ribbon', version: '2.2.10.RELEASE'
contractTestImplementation group: 'com.netflix.ribbon', name: 'ribbon-core', version: '2.7.18'
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
package uk.gov.hmcts.reform;

import com.fasterxml.jackson.databind.DeserializationFeature;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.json.JsonMapper;
import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;

@Configuration
public class ObjectMapperContractTestConfig {

@Bean
public ObjectMapper objectMapper() {
return JsonMapper.builder()
.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false)
.addModule(new JavaTimeModule())
.build();
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package uk.gov.hmcts.reform.am.client;

import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.cloud.openfeign.EnableFeignClients;

@SpringBootApplication
@EnableFeignClients(basePackages = {
"uk.gov.hmcts.reform.am.client"
})

public class RoleAssignmentServiceConsumerApplication {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,141 @@
package uk.gov.hmcts.reform.am.client;

import au.com.dius.pact.consumer.dsl.DslPart;
import au.com.dius.pact.consumer.dsl.PactDslWithProvider;
import au.com.dius.pact.consumer.junit5.PactConsumerTestExt;
import au.com.dius.pact.consumer.junit5.PactTestFor;
import au.com.dius.pact.core.model.RequestResponsePact;
import au.com.dius.pact.core.model.annotations.Pact;
import au.com.dius.pact.core.model.annotations.PactFolder;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.apache.http.HttpStatus;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.TestInstance;
import org.junit.jupiter.api.extension.ExtendWith;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.test.context.ContextConfiguration;
import org.springframework.test.context.TestPropertySource;
import org.springframework.test.context.junit.jupiter.SpringExtension;
import uk.gov.hmcts.reform.am.model.AssignmentRequest;
import uk.gov.hmcts.reform.am.model.GrantType;
import uk.gov.hmcts.reform.am.model.RoleAssignment;
import uk.gov.hmcts.reform.am.model.RoleAssignmentRequestResource;
import uk.gov.hmcts.reform.am.model.RoleCategory;
import uk.gov.hmcts.reform.am.model.RoleRequest;
import uk.gov.hmcts.reform.am.model.RoleType;

import java.io.IOException;
import java.time.ZonedDateTime;
import java.util.List;
import java.util.Map;

import static io.pactfoundation.consumer.dsl.LambdaDsl.newJsonBody;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;

@ExtendWith(PactConsumerTestExt.class)
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
@PactTestFor(providerName = "am_roleAssignment_createAssignment", port = "8894")
@PactFolder("pacts")
@ExtendWith(SpringExtension.class)
@ContextConfiguration(classes = RoleAssignmentServiceConsumerApplication.class)
@TestPropertySource(properties = "am_role_assignment.api.url=localhost:8894")
public class RoleAssignmentServiceConsumerTest {

private static final String SERVICE_AUTH_TOKEN = "someServiceAuthToken";
private static final String AUTHORIZATION_TOKEN = "Bearer some-access-token";

@Autowired
ObjectMapper objectMapper;

@Autowired
AmApi amApi;

private final ZonedDateTime now = ZonedDateTime.now();

// create
@Pact(provider = "am_roleAssignment_createAssignment", consumer = "fpl_ccdConfiguration")
public RequestResponsePact generatePactFragmentForCreate(PactDslWithProvider builder) throws IOException {
// @formatter:off
return builder
.given("The assignment request is valid with one requested role and replaceExisting flag as false")
.uponReceiving("A request to add a role")
.method("POST")
.path("/am/role-assignments")
.headers("Content-Type", "application/json")
.body(objectMapper.writeValueAsString(buildAssignmentRequest()))
.willRespondWith()
.status(HttpStatus.SC_CREATED)
.headers(Map.of(
"Content-Type", "application/vnd.uk.gov.hmcts.role-assignment-service.create-assignments+json"))
.body(buildCreateResponsePactDsl())
.toPact();
}

@Test
@PactTestFor(pactMethod = "generatePactFragmentForCreate")
public void verifyAssignRole() {
RoleAssignmentRequestResource res = amApi.createRoleAssignment(AUTHORIZATION_TOKEN,
SERVICE_AUTH_TOKEN, buildAssignmentRequest());

assertThat(res.getRoleAssignmentResponse().getRequestedRoles()).asList().hasSize(1);
assertThat(res.getRoleAssignmentResponse().getRequestedRoles().get(0).getStatus()).isEqualTo("APPROVED");
}

private AssignmentRequest buildAssignmentRequest() {
return AssignmentRequest.builder()
.roleRequest(RoleRequest.builder()
.assignerId("assignerId")
.process("fpl-case-service")
.reference("reference")
.replaceExisting(false)
.build())
.requestedRoles(List.of(
RoleAssignment.builder()
.actorId("actorId")
.actorIdType("IDAM")
.beginTime(now)
.endTime(now.plusDays(1))
.attributes(Map.of("jurisdiction", "PUBLICLAW", "caseId", "1234567890123456"))
.grantType(GrantType.STANDARD)
.readOnly(false)
.roleName("allocated-judge")
.roleType(RoleType.CASE)
.roleCategory(RoleCategory.JUDICIAL)
.build()
))
.build();
}

protected DslPart buildCreateResponsePactDsl() {
return newJsonBody(ob -> ob
.object("roleAssignmentResponse", pa -> pa
.array("requestedRoles", ra -> ra
.object(r -> r
.stringType("actorId", "actorId")
.stringType("actorIdType", "IDAM")
.stringType("roleName", "allocated-judge")
.stringType("roleType", "CASE")
.stringType("classification", "PUBLIC")
.stringType("grantType", "STANDARD")
.stringType("roleCategory", "JUDICIAL")
.object("attributes", at -> at
.stringType("jurisdiction", "PUBLICLAW")
.stringType("caseId", "1234567890123456"))
.booleanType("readOnly", false)
.stringType("status", "APPROVED")
.decimalType("beginTime", "endTime")
)
)
.object("roleRequest", rr -> rr
.stringType("assignerId", "assignerId")
.stringType("process", "process")
.stringType("reference", "reference")
.booleanType("replaceExisting", false)
))
).build();
}

// query

// delete
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Data;
import lombok.NoArgsConstructor;

import java.time.ZonedDateTime;
import java.util.List;
Expand All @@ -15,6 +16,7 @@
@JsonInclude(JsonInclude.Include.NON_NULL)
@JsonIgnoreProperties(ignoreUnknown = true)
@AllArgsConstructor
@NoArgsConstructor
public class RoleAssignment {

private String id;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,12 @@
import lombok.Builder;
import lombok.Data;
import lombok.NoArgsConstructor;
import lombok.extern.jackson.Jacksonized;

@Data
@Builder
@NoArgsConstructor
@Jacksonized
@AllArgsConstructor
public class RoleAssignmentRequestResource {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,16 @@
package uk.gov.hmcts.reform.am.model;

import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Data;
import lombok.NoArgsConstructor;
import lombok.extern.jackson.Jacksonized;

@Data
@Builder
@NoArgsConstructor
@Jacksonized
@AllArgsConstructor
public class RoleRequest {

private String assignerId;
Expand Down
Loading