-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dfr 3175 ct postcode field not mandatory amend application details #1772
Dfr 3175 ct postcode field not mandatory amend application details #1772
Conversation
public boolean canHandle(CallbackType callbackType, CaseType caseType, EventType eventType) { | ||
return CallbackType.ABOUT_TO_SUBMIT.equals(callbackType) | ||
&& CaseType.CONTESTED.equals(caseType) | ||
&& (EventType.AMEND_CONTESTED_APP_DETAILS.equals(eventType)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is missing an event type. It needs to handle FR_amendApplication and FR_amendPaperApplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, committed here 0c16b58
…---Amend-application-details
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Jira link (if applicable)
DFR-3175
CT - Postcode field not mandatory - Amend application details
Change description
Due to limitations, the validation for the postcode field could not be done in the MidHandler. Refactor of the controller was necessary to implement the AboutToSubmitHandler. Please review carefully.
Tests will be added shortly. Open to suggestions :)
Checklist