Dfr 3175 ct postcode field not mandatory amend application details #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthmcts
reviewed
Jul 9, 2024
| public boolean canHandle(CallbackType callbackType, CaseType caseType, EventType eventType) { | ||
| return CallbackType.ABOUT_TO_SUBMIT.equals(callbackType) | ||
| && CaseType.CONTESTED.equals(caseType) | ||
| && (EventType.AMEND_CONTESTED_APP_DETAILS.equals(eventType)); |
There was a problem hiding this comment.
I think this is missing an event type. It needs to handle FR_amendApplication and FR_amendPaperApplication
There was a problem hiding this comment.
Thanks, committed here 0c16b58
…---Amend-application-details
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link (if applicable)
DFR-3175
CT - Postcode field not mandatory - Amend application details
Change description
Due to limitations, the validation for the postcode field could not be done in the MidHandler. Refactor of the controller was necessary to implement the AboutToSubmitHandler. Please review carefully.
Tests will be added shortly. Open to suggestions :)
Checklist