Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFR-2943 d11 served blank #1754

Merged
merged 16 commits into from
Jul 29, 2024
Merged

DFR-2943 d11 served blank #1754

merged 16 commits into from
Jul 29, 2024

Conversation

al-hmcts
Copy link
Contributor

@al-hmcts al-hmcts commented Jun 26, 2024

Jira link (if applicable)

DFR-2943

Merge pending demo test

Change description

Flatten PDFs when downloaded from doc store to be sent to bulkprint

@hmcts-jenkins-d-to-i
Copy link
Contributor

Plan Result (aat)

No changes. Your infrastructure matches the configuration.

Copy link

infracost bot commented Jun 28, 2024

💰 Infracost report

Monthly cost will not change

This comment will be updated when code changes.

@hmcts-jenkins-d-to-i
Copy link
Contributor

Plan Result (prod)

No changes. Your infrastructure matches the configuration.

@ptrelease ptrelease self-requested a review June 28, 2024 09:37
ptrelease
ptrelease previously approved these changes Jun 28, 2024
Copy link

github-actions bot commented Jul 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 6, 2024
@github-actions github-actions bot closed this Jul 14, 2024
@al-hmcts al-hmcts reopened this Jul 17, 2024
@al-hmcts al-hmcts dismissed stale reviews from hamzahtahirhmcts and ptrelease via 35e2baf July 23, 2024 11:33
Copy link
Contributor

@so99y so99y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 35e2baf. It makes sense to me.

random = {
source = "hashicorp/random"
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autogenerated file added this, don't think this needs changing?

@@ -3,5 +3,5 @@ variable "product" {}
variable "env" {}

variable "common_tags" {
type = map(string)
type = map(string)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autogenerated file added this, don't think this needs changing?

@al-hmcts al-hmcts merged commit 07735f7 into master Jul 29, 2024
5 checks passed
@al-hmcts al-hmcts deleted the DFR-2943-D11-served-blank branch July 29, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants