DFR-3127 child info mapper #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se-orchestration-service into DFR-3127-ChildInfoMapper
hmcts-jenkins-d-to-i
bot
added
ns:financial-remedy
prd:finrem
rel:finrem-cos-pr-1745
labels
so99y
reviewed
Jun 19, 2024
src/main/java/uk/gov/hmcts/reform/finrem/caseorchestration/model/ccd/Gender.java
Show resolved
Hide resolved
so99y
reviewed
Jun 19, 2024
...orm/finrem/caseorchestration/service/bulkscan/transformation/FormAToCaseTransformerTest.java
Outdated
Show resolved
Hide resolved
so99y
reviewed
Jun 19, 2024
...orm/finrem/caseorchestration/service/bulkscan/transformation/mappers/ChildrenInfoMapper.java
Outdated
Show resolved
Hide resolved
|
LGTM. @al-hmcts Just a few minor issues. |
so99y
previously approved these changes
Jun 19, 2024
jthmcts
reviewed
Jun 19, 2024
...orm/finrem/caseorchestration/service/bulkscan/transformation/mappers/ChildrenInfoMapper.java
Outdated
Show resolved
Hide resolved
jthmcts
previously approved these changes
Jun 19, 2024
so99y
previously approved these changes
Jun 19, 2024
ptrelease
approved these changes
Jul 2, 2024
so99y
approved these changes
Jul 3, 2024
hamzahtahirhmcts
approved these changes
Jul 3, 2024
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link (if applicable)
DFR-3127
DFR-3142
Change description
Handle empty strings passed in from OCR to enum mapped fields ChildInfo -> Gender and NatureOfApplication5b.
Note: data zap needs to go in before this is merged to set all empty string values for gender to "notGiven"
Checklist