DMP-2402: Upload audio to azure directly from DARTS gateway #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ben-Edwards-cgi
requested review from
davet1985,
jackmaloney and
hemantasharma1129
and removed request for
a team
Ben-Edwards-cgi
changed the title
hmcts-jenkins-cnp
bot
added
ns:darts-modernisation
prd:darts
rel:darts-gateway-pr-611
labels
cmagowan-hmcts
approved these changes
Nov 13, 2024
| ## See https://learn.microsoft.com/en-us/azure/storage/blobs/storage-blobs-tune-upload-download-java | ||
| block-size-bytes: 10_000_000 | ||
| max-single-upload-size-bytes: 10_000_000 | ||
| max-concurrency: 5 |
There was a problem hiding this comment.
is this restricting the number of uploads to blob storage at once?
if we have 155 courthouses, would this need to be bigger?
@hemantasharma1129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Change description
Transferring audio files between the Proxy and the API for upload to Azure was observed to be slow during performance testing. To address, the proxy should upload the audio file to Azure blob store directly, instead of sending over to the API. In case of failure, the metadata will be stored in Azure blob store, associated to the audio file. Then, the new /audio/metadata endpoint (DMP-4115) in DARTS API should be invoked from the Proxy to save the metadata of the audio file to the database.
This change should also be applied to the Gateway. If this is not trivial to just copy the code across please raise a new ticket to track.
h3. Acceptance criteria
AC1: Send audio and metadata into DARTS Proxy
GIVEN an audio file is sent
WHEN it is received into the Proxy
THEN the audio file and metadata is uploaded to Azure Blob store
AND the metadata is sent to the DARTS API and associated with the correct case
AC2: Send audio and metadata into DARTS Gateway
GIVEN an audio file is sent
WHEN it is received into the Gateway
THEN the audio file and metadata is uploaded to Azure Blob store
AND the metadata is sent to the DARTS API and associated with the correct case
Does this PR introduce a breaking change? (check one with "x")