-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency jsonwebtoken to v9 [SECURITY] #3630
Open
renovate
wants to merge
1
commit into
master
Choose a base branch
from
renovate/npm-jsonwebtoken-vulnerability
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
October 18, 2023 16:22
b7e6726
to
a10411e
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
November 23, 2023 11:39
a10411e
to
cc0bcd3
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
November 24, 2023 09:48
cc0bcd3
to
47b7771
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
November 24, 2023 11:42
47b7771
to
09c8037
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
2 times, most recently
from
November 30, 2023 01:06
1f637c5
to
09eaffe
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
February 8, 2024 15:17
09eaffe
to
7ff1c19
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
March 8, 2024 09:26
7ff1c19
to
993e02e
Compare
⚠ Artifact update problemRenovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is. ♻ Renovate will retry this branch, including artifacts, only when one of the following happens:
The artifact failure details are included below: File name: yarn.lock
|
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
March 8, 2024 14:13
993e02e
to
d499c06
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
March 18, 2024 10:34
d499c06
to
544740b
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
3 times, most recently
from
April 12, 2024 12:58
fc93035
to
eaf4e88
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
2 times, most recently
from
April 19, 2024 13:06
afd26cc
to
628acad
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
May 1, 2024 16:18
628acad
to
e9e790a
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
May 22, 2024 15:12
e9e790a
to
a53cd46
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
July 18, 2024 15:56
a53cd46
to
9686908
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
July 22, 2024 08:29
9686908
to
b60dcc1
Compare
renovate
bot
force-pushed
the
renovate/npm-jsonwebtoken-vulnerability
branch
from
August 8, 2024 11:37
b60dcc1
to
23cd44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^8.5.1
->^9.0.0
GitHub Vulnerability Alerts
CVE-2022-23539
Overview
Versions
<=8.5.1
ofjsonwebtoken
library could be misconfigured so that legacy, insecure key types are used for signature verification. For example, DSA keys could be used with the RS256 algorithm.Am I affected?
You are affected if you are using an algorithm and a key type other than the combinations mentioned below
And for Elliptic Curve algorithms:
alg
How do I fix it?
Update to version 9.0.0. This version validates for asymmetric key type and algorithm combinations. Please refer to the above mentioned algorithm / key type combinations for the valid secure configuration. After updating to version 9.0.0, If you still intend to continue with signing or verifying tokens using invalid key type/algorithm value combinations, you’ll need to set the
allowInvalidAsymmetricKeyTypes
option totrue
in thesign()
and/orverify()
functions.Will the fix impact my users?
There will be no impact, if you update to version 9.0.0 and you already use a valid secure combination of key type and algorithm. Otherwise, use the
allowInvalidAsymmetricKeyTypes
option totrue
in thesign()
andverify()
functions to continue usage of invalid key type/algorithm combination in 9.0.0 for legacy compatibility.CVE-2022-23541
Overview
Versions
<=8.5.1
ofjsonwebtoken
library can be misconfigured so that passing a poorly implemented key retrieval function (referring to thesecretOrPublicKey
argument from the readme link) will result in incorrect verification of tokens. There is a possibility of using a different algorithm and key combination in verification than the one that was used to sign the tokens. Specifically, tokens signed with an asymmetric public key could be verified with a symmetric HS256 algorithm. This can lead to successful validation of forged tokens.Am I affected?
You will be affected if your application is supporting usage of both symmetric key and asymmetric key in jwt.verify() implementation with the same key retrieval function.
How do I fix it?
Update to version 9.0.0.
Will the fix impact my users?
There is no impact for end users
CVE-2022-23540
Overview
In versions <=8.5.1 of jsonwebtoken library, lack of algorithm definition and a falsy secret or key in the
jwt.verify()
function can lead to signature validation bypass due to defaulting to thenone
algorithm for signature verification.Am I affected?
You will be affected if all the following are true in the
jwt.verify()
function:How do I fix it?
Update to version 9.0.0 which removes the default support for the none algorithm in the
jwt.verify()
method.Will the fix impact my users?
There will be no impact, if you update to version 9.0.0 and you don’t need to allow for the
none
algorithm. If you need 'none' algorithm, you have to explicitly specify that injwt.verify()
options.Release Notes
auth0/node-jsonwebtoken (jsonwebtoken)
v9.0.0
Compare Source
Breaking changes: See Migration from v8 to v9
Breaking changes
8345030
]auth0/node-jsonwebtoken@8345030)ecdf6cc
]auth0/node-jsonwebtoken@ecdf6cc)Security fixes
Arbitrary File Write via verify function
- CVE-2022-23529Insecure default algorithm in jwt.verify() could lead to signature validation bypass
- CVE-2022-23540Insecure implementation of key retrieval function could lead to Forgeable Public/Private Tokens from RSA to HMAC
- CVE-2022-23541Unrestricted key type could lead to legacy keys usage
- CVE-2022-23539Configuration
📅 Schedule: Branch creation - "" in timezone Europe/London, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.