SDT-231: Rework integration with service bus #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed feature flags from application.yaml - Added service bus properties to integration test application YAML files. - Added connection factory configuration class for creating a connection factory for the service bus. - Added a test connection factory configuration class for creating a connection factory for ActiveMQ which is used by the integration tests. - Updated integration tests to include test connection factory configuration class. - Removed feature flag from JmsTemplateConfig class. - Removed feature flag and associated queue reset code from MessageWriter class. - Removed feature flag and associated single executor code from MessagingUtility class. - Added RequeueIndividualRequestUtility class. - Amended SdtManagementMBean class to use RequeueIndividualRequestUtility class instead of MessagingUtility class. Also removed redundant code and refactored logging statements. - Updated SdtManagementMBeanTest class to reflect changes to SdtManagementMBean. Removed redundant code.
- Removed extra debug logging that was added to MessagingUtility and MessageWriter.
RebeccaBaker
previously approved these changes
Aug 21, 2024
Added enable-new-queue-process feature flag to allow switching between the different methods of integration with service bus. The changes make the queue reset code in MessageWriter that was behind the enable-queue-reset flag the normal path. This allows a single feature flag to control the service bus integration method used.
Plan Result (aat) |
Plan Result (prod) |
RebeccaBaker
approved these changes
Aug 28, 2024
hemantt
approved these changes
Sep 2, 2024
|
Reviewed and tested with @paulridout locally |
hemantt
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
SDT-231 (https://tools.hmcts.net/jira/browse/SDT-231)
Change description
Does this PR introduce a breaking change? (check one with "x")