DTSCCI-000 SNI-5921 stop creating wa task when uploading additional document #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishikrsharma
changed the title
ruban72
reviewed
Jul 17, 2024
| @@ -310,7 +310,7 @@ public class CaseData implements MappableObject { | |||
| private final String judgeTitle; | |||
|
|
|||
| private final List<Element<UploadDocumentByType>> uploadDocument; | |||
|
|
|||
| private final YesOrNo isWaTaskRequired; | |||
There was a problem hiding this comment.
Can we rename this to make it more specific to the WA task that we are trying to prevent being created as the name seems to be too generic
There was a problem hiding this comment.
done - as we discusssed
ruban72
approved these changes
Jul 17, 2024
rishikrsharma
deleted the
SNI-5921-stop-creating-task-on-upload-order-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
SNI-5921
Change description
stop creating wa task when uploading additional document
Testing branch and instruction
Does this PR introduce a breaking change? (check one with "x")