Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay 4718 Orders GET APIs #1037

Closed
wants to merge 24 commits into from
Closed

Conversation

sayali-salunkhe
Copy link
Contributor

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Attention: Patch coverage is 77.68344% with 368 lines in your changes are missing coverage. Please review.

Project coverage is 80.29%. Comparing base (ec8252e) to head (d61cff3).
Report is 5509 commits behind head on master.

❗ Current head d61cff3 differs from pull request most recent head ada622b. Consider uploading reports for the commit ada622b to get more accurate results

Files Patch % Lines
...t/api/domain/service/PaymentDomainServiceImpl.java 53.36% 69 Missing and 21 partials ⚠️
.../gov/hmcts/payment/api/service/IacServiceImpl.java 4.00% 48 Missing ⚠️
.../payment/api/contract/RetrieveOrderPaymentDto.java 0.00% 45 Missing ⚠️
.../uk/gov/hmcts/payment/api/contract/CaseFeeDto.java 0.00% 26 Missing ⚠️
...hmcts/payment/api/dto/mapper/PaymentDtoMapper.java 86.80% 1 Missing and 18 partials ⚠️
.../payment/api/contract/TelephonyPaymentRequest.java 22.22% 12 Missing and 2 partials ⚠️
...ayment/api/controllers/PaymentGroupController.java 92.09% 6 Missing and 8 partials ⚠️
...ent/api/domain/service/OrderDomainServiceImpl.java 84.70% 7 Missing and 6 partials ⚠️
...cts/payment/api/controllers/PaymentController.java 89.74% 1 Missing and 11 partials ⚠️
...trollers/ReplayCreditAccountPaymentController.java 86.30% 7 Missing and 3 partials ⚠️
... and 31 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1037      +/-   ##
============================================
- Coverage     81.50%   80.29%   -1.21%     
- Complexity     1619     1764     +145     
============================================
  Files           261      272      +11     
  Lines          5207     5654     +447     
  Branches        336      384      +48     
============================================
+ Hits           4244     4540     +296     
- Misses          774      897     +123     
- Partials        189      217      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants