Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EUI-2976: ExUI strategic solution #276

Open
wants to merge 66 commits into
base: master
Choose a base branch
from

Conversation

paul-graham
Copy link

@paul-graham paul-graham commented May 25, 2021

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/EUI-4128DONE
https://tools.hmcts.net/jira/browse/EUI-4131DONE
https://tools.hmcts.net/jira/browse/EUI-4135DONE
https://tools.hmcts.net/jira/browse/EUI-4137DONE
(All under https://tools.hmcts.net/jira/browse/EUI-2976)

Change description

Introduced socket.io to provide a mechanism for watching activity on a list of cases and indicating when a user is viewing or editing a given case. This mirrors the functionality already in the activity tracker but uses "sockets" (websockets or long polling, depending on the client configuration) and does away with the need for repeated polling.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No, but I'd still suggest it should be a major release

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #276 (442f9b1) into master (509d54c) will increase coverage by 12.62%.
The diff coverage is 93.47%.

❗ Current head 442f9b1 differs from pull request most recent head 3f19129. Consider uploading reports for the commit 3f19129 to get more accurate results

@@             Coverage Diff             @@
##           master     #276       +/-   ##
===========================================
+ Coverage   73.98%   86.60%   +12.62%     
===========================================
  Files          24       37       +13     
  Lines         419      672      +253     
===========================================
+ Hits          310      582      +272     
+ Misses        109       90       -19     
Impacted Files Coverage Δ
app/security/cors.js 20.83% <0.00%> (-0.91%) ⬇️
server.js 0.00% <0.00%> (ø)
app/job/store-cleanup-job.js 35.00% <62.50%> (-3.47%) ⬇️
app/redis/instantiator.js 80.95% <80.95%> (ø)
app.js 76.08% <100.00%> (-0.51%) ⬇️
app/redis/redis-client.js 100.00% <100.00%> (+22.72%) ⬆️
app/routes/validate-request.js 100.00% <100.00%> (ø)
app/service/activity-service.js 100.00% <100.00%> (ø)
app/service/ttl-score-generator.js 100.00% <100.00%> (+50.00%) ⬆️
app/socket/index.js 100.00% <100.00%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview May 28, 2021 10:20 Inactive
@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview May 28, 2021 18:48 Inactive
@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview June 9, 2021 12:12 Inactive
@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview June 9, 2021 12:18 Inactive
@paul-graham paul-graham marked this pull request as ready for review June 9, 2021 12:33
@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview June 9, 2021 12:53 Inactive
@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview June 10, 2021 08:53 Inactive
@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview June 10, 2021 10:44 Inactive
@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview July 8, 2021 08:58 Inactive
@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview July 8, 2021 09:03 Inactive
@udaydenduluri33
Copy link

In general all the parameters are missing the types. I will look at this PR once all the types are strongly typed. Thanks.

@paul-graham
Copy link
Author

In general all the parameters are missing the types. I will look at this PR once all the types are strongly typed. Thanks.

This is a JavaScript project, not a TypeScript one. Therefore, no strong typing. 😁

Copy link

@udaydenduluri33 udaydenduluri33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that existing functionality is not touched
socket.io is introduced as an additional enhancement which could be feature toggled from application

@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview July 15, 2021 10:49 Inactive
@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview July 19, 2021 15:11 Inactive
@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview July 19, 2021 15:58 Inactive
@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview July 19, 2021 16:07 Inactive
@hmcts-jenkins-cdm hmcts-jenkins-cdm bot temporarily deployed to preview July 19, 2021 16:28 Inactive
Introduced a basic mechanism for accepting "socket" connections via socket.io and responding to various messages from the client. The code is messy and all inline at the moment but it needs to get into the repo sooner rather than later.
Very small tweak to return the user name rather than their ID in the response and case listing.
@hmcts-jenkins-a-to-c hmcts-jenkins-a-to-c bot requested a deployment to preview March 20, 2023 10:47 Abandoned
@hmcts-jenkins-a-to-c hmcts-jenkins-a-to-c bot requested a deployment to preview March 20, 2023 10:49 Abandoned
Copy link

@Mo-Lala84 Mo-Lala84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-helm Do Not Uninstall Helm Release on Success ns:ccd pinned prd:ccd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants