Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTSAM-427: FTAs for ST Judicial Appointments #2065

Merged
merged 18 commits into from
Oct 10, 2024
Merged

DTSAM-427: FTAs for ST Judicial Appointments #2065

merged 18 commits into from
Oct 10, 2024

Conversation

SivaKanukolluQA
Copy link
Contributor

@SivaKanukolluQA SivaKanukolluQA commented Aug 28, 2024 •
edited by mattnayler
Loading

Jira link

https://tools.hmcts.net/jira/browse/DTSAM-427

Change description

Adding FTAs for ST Judicial appointments

NB: this PR is branched from: #2095

Testing done

This is Automation Testing ticket itself.

Checklist

  • Does this PR introduce a breaking change - no

@hmcts-jenkins-a-to-c hmcts-jenkins-a-to-c bot requested a deployment to preview September 12, 2024 08:43 Abandoned
@SivaKanukolluQA SivaKanukolluQA added the enable_keep_helm Do not uninstall helm release after pipeline completion label Sep 12, 2024
@SivaKanukolluQA SivaKanukolluQA changed the base branch from master to DTSAM-521_ST_CIC_WA_judicial_mappings_update September 30, 2024 09:56
mikebrownccd
mikebrownccd previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@mikebrownccd mikebrownccd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abul-syed
abul-syed previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@abul-syed abul-syed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mattnayler
mattnayler previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@mattnayler mattnayler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from DTSAM-521_ST_CIC_WA_judicial_mappings_update to master October 9, 2024 15:03
@mikebrownccd mikebrownccd dismissed stale reviews from mattnayler, abul-syed, and themself October 9, 2024 15:03

The base branch was changed.

@hmcts-jenkins-a-to-c
Copy link
Contributor

Plan Result (aat)

No changes. Your infrastructure matches the configuration.

@hmcts-jenkins-a-to-c
Copy link
Contributor

Plan Result (prod)

No changes. Your infrastructure matches the configuration.

mattnayler
mattnayler approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@mattnayler mattnayler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after branch change

mikebrownccd
mikebrownccd approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@mikebrownccd mikebrownccd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrownccd mikebrownccd merged commit e27cd38 into master Oct 10, 2024
7 checks passed
@mikebrownccd mikebrownccd deleted the DTSAM-427_ST_Judicial_ORG_Roles branch October 10, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattnayler mattnayler mattnayler approved these changes

@mikebrownccd mikebrownccd mikebrownccd approved these changes

@abul-syed abul-syed abul-syed left review comments

Assignees
No one assigned
Labels
aat/no-changes enable_keep_helm Do not uninstall helm release after pipeline completion ns:am prd:am prod/no-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SivaKanukolluQA @mattnayler @mikebrownccd @abul-syed