-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTSAM-290 SSCS_WA_1_1 add 4 sscs judicial appts #1906
Open
abul-syed
wants to merge
7
commits into
COT-801-Addition-of-ticket-check
Choose a base branch
from
DTSAM-290_add_sscs_judicial_appt
base: COT-801-Addition-of-ticket-check
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DTSAM-290 SSCS_WA_1_1 add 4 sscs judicial appts #1906
abul-syed
wants to merge
7
commits into
COT-801-Addition-of-ticket-check
from
DTSAM-290_add_sscs_judicial_appt
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmcts-jenkins-a-to-c
bot
added
ns:am
prd:am
rel:am-org-role-mapping-service-pr-1906
labels
May 13, 2024
mikebrownccd
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
abul-syed
changed the title
DTSAM-290 SSCS_WA_1_1 add 5 sscs judicial appts
DTSAM-290 SSCS_WA_1_1 add 4 sscs judicial appts
Jun 4, 2024
Merging the PR into upstream branch as SSCS have confirmed that the Recorder Salaried appointment is not required.
mattnayler
requested changes
Jun 12, 2024
...java/uk/gov/hmcts/reform/orgrolemapping/domain/service/DroolSscsJudicialRoleMappingTest.java
Outdated
Show resolved
Hide resolved
mattnayler
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mikebrownccd
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link (if applicable)
https://tools.hmcts.net/jira/browse/DTSAM-290
Change description
SSCS_WA_1_1 Add 4 remaining missing SSCS appointments
NB: PR has a dependency on #1796