Skip to content

Commit

Permalink
feat(content-recorder): implement ThreadFallbackManager for non-multi…
Browse files Browse the repository at this point in the history
…threading scenarios and update initialization logic
  • Loading branch information
hm21 committed Jan 21, 2025
1 parent 59f247d commit 71a3a74
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import '/shared/utils/unique_id_generator.dart';
import '../services/image_converter_service.dart';
import '../services/image_render_service.dart';
import '../services/isolate_manager.dart';
import '../services/thread_fallback_manager.dart';
import '../services/thread_manager.dart';
import '../services/web_worker/web_worker_manager_dummy.dart'
if (dart.library.js_interop) '../services/web_worker/web_worker_manager.dart';
Expand All @@ -35,7 +36,7 @@ class ContentRecorderController {
recorderKey = GlobalKey();
recorderStream = StreamController();

if (!ignoreGeneration) _initializeMultiThreading();
_initializeMultiThreading(ignoreGeneration);
}

/// A flag indicating whether thumbnail generation is enabled.
Expand Down Expand Up @@ -66,8 +67,10 @@ class ContentRecorderController {
Completer<bool> recordReadyHelper = Completer();

/// Sets up the multi-threading environment, using isolates or web workers.
void _initializeMultiThreading() async {
if (!kIsWeb) {
void _initializeMultiThreading(bool ignoreGeneration) async {
if (ignoreGeneration) {
_threadManager = ThreadFallbackManager(_configs);
} else if (!kIsWeb) {
_threadManager = IsolateManager(_configs);
} else {
_threadManager = WebWorkerManager(_configs);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import 'package:pro_image_editor/shared/services/content_recorder/services/thread_manager.dart';

/// Fallback manager for ThreadManager if multithreading isn't required.
class ThreadFallbackManager extends ThreadManager {
/// Constructs a `ThreadFallbackManager` instance with the specified configuration and
/// initializes the threading environment.
ThreadFallbackManager(super.configs);

@override
void initialize() {
// No initialization required for fallback manager.
}
}

0 comments on commit 71a3a74

Please sign in to comment.