Skip to content

Enable Configuration Cache#220

Open
tmvkrpxl0 wants to merge 1 commit intohlysine:mainfrom
tmvkrpxl0:enable-cache
Open

Enable Configuration Cache#220
tmvkrpxl0 wants to merge 1 commit intohlysine:mainfrom
tmvkrpxl0:enable-cache

Conversation

@tmvkrpxl0
Copy link
Copy Markdown

This PR enables Configuration Cache that was explicitly disabled. I assume reason for it is it throws error when it's enabled.
To explain why it throws error, this part of the code:

    filesMatching(['META-INF/neoforge.mods.toml', 'pack.mcmeta']) {
        expand replaceProperties + [project: project]
    }

uses object project to replace "${project}" in those files. but I don't see mention of word project in both toml and mcmeta files. so it can be removed.

(cherry picked from commit d03413e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant