fevo script injection for buttons #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
Mark-M-Ensemble
approved these changes
Jul 28, 2023
|
Admittedly I don't know a ton about fevo, but is there a reason this isn't in delayed? |
|
i thought the same thing... i think ideally a placeholder would be loaded on the inject code would only executed on click. |
Fair point, I did this quickly and didn't give it a ton of thought tbh, delayed seems the right place. |
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test URLs:
See https://adobe-dx-support.slack.com/archives/C03GXBSC72T/p1690550356398579
Note, the fevo offer never loads on that test page, not a real offer code yet, and primarily this is for Fedex st. Jude, just doing it here so I can merge it to other tournament sites.