Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDW-1646 Add Admiral Script #122

Merged
merged 3 commits into from
Apr 15, 2024
Merged

TDW-1646 Add Admiral Script #122

merged 3 commits into from
Apr 15, 2024

Conversation

13onnie
Copy link
Collaborator

@13onnie 13onnie commented Apr 10, 2024

@13onnie 13onnie self-assigned this Apr 10, 2024
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 10, 2024

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

peterwiebe
peterwiebe approved these changes Apr 12, 2024
View reviewed changes
Copy link

@peterwiebe peterwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bosco-ensemble bosco-ensemble self-requested a review April 12, 2024 18:18
@13onnie 13onnie merged commit 23d6d8b into main Apr 15, 2024
2 checks passed
Mark-M-Ensemble
Mark-M-Ensemble reviewed Apr 15, 2024
View reviewed changes
scripts/delayed.js
* Loads Admiral script
*/
function loadAdmiral() {
const fetchScript = async () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the fetchScript function and just make the outer on async?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-M-Ensemble Mark-M-Ensemble Mark-M-Ensemble left review comments

@bosco-ensemble bosco-ensemble bosco-ensemble approved these changes

@peterwiebe peterwiebe peterwiebe approved these changes

Assignees

@13onnie 13onnie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@13onnie @peterwiebe @Mark-M-Ensemble @bosco-ensemble