-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We fevo #103
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
const hasFevo = document.querySelector('a.fevo-btn'); | ||
if (hasFevo) { | ||
injectFevoScript(); | ||
} | ||
|
||
const hasWeFevo = document.querySelector('a.we-fevo-btn'); | ||
if (hasWeFevo) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (hasFevo || hasWeFevo)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so?
Not at all confident this is right, but my understanding from Gary is that there are 2 types of fevo buttons, but they aren't related beyond the fact that they come from the same vendor. but also that there could at least in theory exist both types of buttons on the same page.
so they presence of a "normal" fevo button does not necessitate loading the sdk for the "we fevo" type, and vice versa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. I definitely read this wrong. Thank you.
|
https://wefevo--theplayers--hlxsites.hlx.page/hospitality
extend fevo button decoration to support weFevo.