Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We fevo #103

Merged
merged 4 commits into from
Sep 28, 2023
Merged

We fevo #103

merged 4 commits into from
Sep 28, 2023

Conversation

shsteimer
Copy link
Collaborator

https://wefevo--theplayers--hlxsites.hlx.page/hospitality

extend fevo button decoration to support weFevo.

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Page Scores Audits Google
/hospitality PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Page Scores Audits Google
/hospitality PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

const hasFevo = document.querySelector('a.fevo-btn');
if (hasFevo) {
injectFevoScript();
}

const hasWeFevo = document.querySelector('a.we-fevo-btn');
if (hasWeFevo) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (hasFevo || hasWeFevo)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so?

Not at all confident this is right, but my understanding from Gary is that there are 2 types of fevo buttons, but they aren't related beyond the fact that they come from the same vendor. but also that there could at least in theory exist both types of buttons on the same page.

so they presence of a "normal" fevo button does not necessitate loading the sdk for the "we fevo" type, and vice versa.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I definitely read this wrong. Thank you.

@aem-code-sync
Copy link

aem-code-sync bot commented Sep 28, 2023

Page Scores Audits Google
/hospitality PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@shsteimer shsteimer merged commit 5045c6a into main Sep 28, 2023
2 checks passed
@shsteimer shsteimer deleted the weFevo branch September 28, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants