Pdf viewer issue #364
Merged
Pdf viewer issue #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sachinmesh
suggested changes
Dec 21, 2023
There was a problem hiding this comment.
The PDF viewer should crossover to the leadspace like this, the padding between the download link and the PDF viewer is 64px.
Sharing the figma here
https://www.figma.com/file/FSqQ1LYrVSssEFOZuOnMIE/Final-page-layouts-for-Merative.com?type=design&node-id=202-83543&mode=dev
sachinmesh
approved these changes
Dec 22, 2023
sachinmesh
added
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #MERATIVE-951
Description
On desktop the pdf viewer is being cut off. It looks like there is too much space between the download pdf link and the when the pdf starts. The PDF viewer embed is hidden behind the leadspace. THis must have been some regression from another update.
Test URLs
main): https://www.merative.com/documents/brief/user-trends-article-bl