-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pdf viewer issue #364
Pdf viewer issue #364
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PDF viewer should crossover to the leadspace like this, the padding between the download link and the PDF viewer is 64px.
Sharing the figma here
https://www.figma.com/file/FSqQ1LYrVSssEFOZuOnMIE/Final-page-layouts-for-Merative.com?type=design&node-id=202-83543&mode=dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Iframe is now overlapping the leadspace as per design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Issue
Fixes #MERATIVE-951
Description
On desktop the pdf viewer is being cut off. It looks like there is too much space between the download pdf link and the when the pdf starts. The PDF viewer embed is hidden behind the leadspace. THis must have been some regression from another update.
Test URLs
main
): https://www.merative.com/documents/brief/user-trends-article-bl