Stat with illustration padding issue #363
Conversation
nimithshetty17
requested review from
anabarcelona,
keith-kaplan and
sachinmesh
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
@keith-kaplan have added the bottom padding. Let me know if this is ok. |
There was a problem hiding this comment.
@nimithshetty17 can we also add a class or add an edit that will make remove the top padding. I think it's default at 160px.
|
@keith-kaplan have added a block with stat-with-illustration(no-padding) to add an optional padding. Let me know if this is ok. Can be reviewed here:- https://main--merative2--nimithshetty17.hlx.page/block-library/blocks/stat-with-illustration |
|
I do not see the no-padding on top working. Can you check?
|
|
@keith-kaplan sorry I copied the wrong url here. This is the right url:-https://stat-with-illustration-padding-issue--merative2--nimithshetty17.hlx.page/block-library/blocks/stat-with-illustration |
|
No worries. This looks good to me. @sachinmesh @anabarcelona want to take a look? https://stat-with-illustration-padding-issue--merative2--nimithshetty17.hlx.page/drafts/Keith/real-world-evidence-copy This is the block library variations we have https://stat-with-illustration-padding-issue--merative2--nimithshetty17.hlx.page/block-library/blocks/stat-with-illustration |
|
@nimithshetty17 I just saw the Figma file. I think we need to make the number stat a gradient like the content intro stat block. |
|
The width of the stat component is wrong, it should be desktop is 360px, tablet 275px, mobile 270px @nimithshetty17 
|
|
|
@sachinmesh please check now. |
There was a problem hiding this comment.
Checked this URL
https://stat-with-illustration-padding-issue--merative2--nimithshetty17.hlx.page/drafts/Keith/real-world-evidence-copy
Looks good to me.
sachinmesh
added
the
Ready to merge
Fixes MERATIVE-950
Description
The stat with illustration block was designed to only have an image below it. We would like to update this block to ensure there is the proper padding added above/below when an image is not present.
Test URLs
main): https://main--merative2--hlxsites.hlx.page/drafts/Keith/real-world-evidence-copy