Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leadspace anchor link update #362

Merged

Conversation

nimithshetty17
Copy link

Fixes #MERATIVE-928

Description

Update homepage leadspace to include anchor link to scroll. Also add arrow seen in design.

Design Specs

If applicable, add the direct link to the design specs of the component/feature that's part of this PR.

Test URLs

Copy link

aem-code-sync bot commented Dec 5, 2023

Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

Copy link

aem-code-sync bot commented Dec 5, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

@sachinmesh sachinmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SCROLL font size should be 14px Alliance no.1 medium and not 15px @nimithshetty17
image

CC: @keith-kaplan @anabarcelona

@sachinmesh sachinmesh added Ready to merge Label for the pull requests that are ready to merge and removed 🛠️ fix needed labels Dec 5, 2023
Copy link

@sachinmesh sachinmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrections are done. @nimithshetty17

CC: @keith-kaplan @anabarcelona

Copy link
Collaborator

@keith-kaplan keith-kaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@keith-kaplan keith-kaplan merged commit e3dcf95 into hlxsites:main Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants