Content intro stat issue #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimithshetty17
requested review from
anabarcelona,
keith-kaplan and
sachinmesh
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
sachinmesh
suggested changes
Dec 4, 2023
There was a problem hiding this comment.
@nimithshetty17
On desktop and mobile the width of the stat componenet is correct.
only on taablet it should be 275 px.
Here is the figma link of the stat component.
|
@sachinmesh please review now. |
sachinmesh
suggested changes
Dec 5, 2023
There was a problem hiding this comment.
@nimithshetty17 Earlier it was correct on desktop i.e 360px..now its wrong, also its crossing the right padding also..
on tablet it is correct now.
sachinmesh
added
Ready to merge
|
I'll merge this later this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes MERATIVE-948
Description
The content intro stats block is not rendering properly when there is along stat in the right column. there seems to be a CSS style that limits the width of the stat number.
Test URLs
main): https://main--merative2--hlxsites.hlx.page/block-library/blocks/content-intro