Image content grid block #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimithshetty17
requested review from
anabarcelona,
keith-kaplan and
sachinmesh
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
sachinmesh
suggested changes
Nov 20, 2023
There was a problem hiding this comment.
- Spacing between the list heading and paragrpagh below it should be 16px and not 24px.
- The list container size is wrong
- The image container size is wrong. The image and the text on the right should have 120px spacing
- On mobile, the spacing between the list heading and paragraph below should be 16px and not 24px.
- waiting for the bone background version also.
|
|
|
@sachinmesh please find the fixes below:-
|
Sharing the figma file here. https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?type=design&node-id=21610-14449&mode=design&t=D6dm8a9w1cfpxcQ3-4 |
|
|
Good to go @nimithshetty17 @keith-kaplan @anabarcelona |
sachinmesh
approved these changes
Nov 22, 2023
sachinmesh
added
Ready to merge
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #MERATIVE-910
Description
Creation of the image content grid block.
Test URLs
main): https://main--merative2--nimithshetty17.hlx.page/block-library/blocks/image-content-grid