-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navattic page blocks. #355
Navattic page blocks. #355
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
|
@nimithshetty17 let's make the footer for the demos a Fragment since that shouldn't be changed by an author. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
@keith-kaplan have created and added two fragments for the footer from the approach Charity had suggested and they can be viewed here:- https://navattic-page-blocks--merative2--nimithshetty17.hlx.page/drafts/nimith/navattic-updated. |
|
@sachinmesh the below issues are addressed:-
Please have a look and let me know if there are more. |
@nimithshetty17 I created another demo for Micromedex and just saw that the CTA styling is broken when only using on button. Can we make sure the formatting is still correct even if one CTA is present? https://navattic-page-blocks--merative2--nimithshetty17.hlx.page/clinical-decision-support/demo |
@keith-kaplan for solution it has to be authored by adding a field called CTA and the buttons below. Please check https://navattic-page-blocks--merative2--nimithshetty17.hlx.page/clinical-decision-support/demo. |
|
|
Looking good to me. Thank you @nimithshetty17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@sachinmesh - Removed the white line below iframe. |
Footer links are missing, rest is good to go @nimithshetty17 @keith-kaplan |
|
@sachinmesh - Footer issues have been addressed. |
Issue
Fixes #MERATIVE-871
Description
This is a request made to improve/optimize the user experience of the Navattic demo
The demo page template currently lives within AEM, however, it needs to be moved into Franklin as part of the phase 3 migration effort.
Test URLs
main
): https://main--merative2--hlxsites.hlx.page/drafts/nimith/navattic-page