Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WCAG compliant tabs block #135

Merged
merged 26 commits into from
Apr 13, 2023
Merged

feat: add WCAG compliant tabs block #135

merged 26 commits into from
Apr 13, 2023

Conversation

ramboz
Copy link
Collaborator

@ramboz ramboz commented Apr 5, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 5, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 5, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 5, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 6, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 6, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI

@ramboz ramboz marked this pull request as ready for review April 6, 2023 17:59
@aem-code-sync
Copy link

aem-code-sync bot commented Apr 6, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 6, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview Lighthouse returned error: Something went wrong. PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 6, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 6, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 6, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 6, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 6, 2023

Page Score PSI Audit Google
/us/en/skymiles/how-to-earn-miles/overview SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 6, 2023

@askayastha22
Copy link
Collaborator

Slight spacing and font adjustment required to style the tabs like on the original page.
Screenshot 2023-04-06 at 7 57 14 PM

Screenshot 2023-04-06 at 7 56 59 PM

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 7, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 7, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 7, 2023

@askayastha22
Copy link
Collaborator

@ramboz @Dereje24 I have fixed the tables belonging to Hertz to be nested inside the Hertz accordion. Only change was replacing the existing content with Hertz's accordion doc link.

PS: Note that the pager isn't displayed right now because this is a draft doc with a different relative URL.

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 7, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 7, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 7, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 7, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 8, 2023

@ramboz
Copy link
Collaborator Author

ramboz commented Apr 8, 2023

Performance is known to be "bad" here as we have a combination of edge cases we are hitting.
The fix will be addressed in #138

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 13, 2023

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 13, 2023

@ramboz ramboz merged commit cb11e58 into main Apr 13, 2023
@ramboz ramboz deleted the issue106 branch April 13, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement tab toggles
3 participants