Assets 32297 #19
Merged
Assets 32297 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
shiv-gup
reviewed
Dec 6, 2023
styles/gmo-styles.css
Outdated
| /* Adjusts margins for FAQ content using bullet points to remove extra line spacing */ | ||
| .section.faq .default-content-wrapper ul { | ||
| margin: -1em 0 1em 0; | ||
| } |
There was a problem hiding this comment.
@cheintzman can you follow the indentation
shiv-gup
approved these changes
Dec 6, 2023
klcodanr
pushed a commit
that referenced
this pull request
Dec 13, 2023
mathieu-lessard
added a commit
that referenced
this pull request
Mar 14, 2024
* fix: update fstab * Update README.md * ASSETS-3207 integrate Unified shell (#3) * ASSETS-32004 use discovery service to find instances with content hub product profiles (#4) * ASSETS-31822 Create separate security module for Unified Shell * Setup delivery endpoint discovery * docs: update readme * docs: update readme * chore: allow showing 404 page * chore: update sidekick host * chore: remove old comment * fix: update serviceCode===dma_aem_contenthub * fix: don't open browser on "aem up" * ASSETS-32078: Handle changes of imsOrg from Unified Shell * Show spinner while imsOrg changes * fix: use delivery urls from discovery * fix: use delivery urls from discovery * refactor: use page.iframeReload(false); * adapt 404 error page for Unified Shell * feat: reflect url changes from unified shell in app * ASSETS-32075 Hide header bar (logo, user switcher) when using Unified Shell (#5) * ASSETS-32055: POC integration with Upload MFE (#8) * ASSETS-32055: provide bearer token * chore: remove dialog after closing * ASSETS-31831 - Portal style changes for content hub (#6) * chore: fix typo in jsdocs: BrandingConfig.portalTheme * Load Reporting MFE using pure JS * Add css * Add css * Point the reporting MFE to prod * Add discovery call * ASSETS-32176 Keep url in unified shell updated. React to url changes. (#7) Keep url in unified shell updated. React to url changes. handle url changes in asset detail view fix link for link share refactor history listener redirect to /no-access if no delivery env can be found * Accessibility: add role and aria-labels where missing (#10) * quick fix to show reporting in CH * Remove bar graph * fix: cleanup eslint errors * ASSETS-31803 - Refactor Modal code for Unified Shell (#12) * add platform connector * add platform connector with rollup * poc of PlatformConnector * docs: describe rollup * docs: no sudo * cleanup * add PlatformConnector lib * fix: keep existing discovery * cleanup: remove old libs * Update README.md * ASSETS-31899 use PlatfromConnector API for repositoryID * cleanup: only delete dependencies selectively * cleanup: remove unused dependencies * cleanup: undo comment out * cleanup: undo comment out * chore: cleanup imports * PlatformConnector: initial draft (#15) * add platform connector, use rollup to convert library * cleanup after merge * update readme * ASSETS-31899 use franklin lib loadScript based on feedback * ASSETS-31899 add delivery and storageUsage * ASSETS-31831 - Portal changes for content hub (#14) * docs: add sharepoint * fix merge conflicts * ASSETS-31831 - Update style for content hub (#17) * Feat: implement user settings * Feat: implement user settings and redirect users * ASSETS-31899 clear up * Fix modal dialog styling (#18) * ASSETS-31899 remove storageUsage * ASSETS-32522 - Fix upload dialog styling (#19) * add missing import * Feat: Playwright End-2-End test (#11) This is a very simple setup. Expect it to fail for no reason. But it's good to run after making some changes to be sure nothing major broke. * fix: export everything from platform connector * chore: refactor exc-app import/exports * fix: remove text-transform: capitalize; * fix: improve error message when run without unified shell * Fixing to use the IMS org from the site config for GMO * don't call getRepositoryList * Upload dialog (#23) * Fixing to use the distribution url to determine the author repoId * Changing clientid * Adding the version supporting setting metadata * Updating to latest version of the upload MFE * Fixing incorrect mappings * Updating to latest PR build * Updating to new schema * Styling tweaks to the upload dialog * Commented out ProductFamily from 'Add Asset' (#30) * Alphabetize Product List on 'Add Assets' Modal (#32) * DXI-23343: New Multi-required fields. Enable upload on form filled (#34) Co-authored-by: Mathieu Lessard <[email protected]> * DXI-23346: Hydration uses values from Algolia for selections (#35) * DXI-23346: Hydration uses values from Algolia for selections * Adjusted spacing * Adjusted spacing --------- Co-authored-by: Mathieu Lessard <[email protected]> * Updated Asset Upload Experience (#37) * Updated Asset Upload Experience * Added comment regarding why the button change is delayed --------- Co-authored-by: Mathieu Lessard <[email protected]> * Enabled Perpetuity Option * Fixed license date to use ISO instead of epoch * Refactored code * 'Add Assets' button can now be hidden by IMS group (#44) - Added checkAddAssetsAccess() that will compare 'imsAuthorGroup' in 'admin-config.xlsx' in sharepoint to the IMS groups of the current user. - Code that loads the 'Add Assets' button will now not execute unless checkAddAssetsAccess() returns true. * Removed Keywords from Asset Upload * Renamed LisenceDate Property * Renamed LisenceDate Property --------- Co-authored-by: Aravindo Wingeier <[email protected]> Co-authored-by: Aravindo Wingeier <[email protected]> Co-authored-by: Andrew Khoury <[email protected]> Co-authored-by: Narendra Katamaneni <[email protected]> Co-authored-by: Cris Rockwell <[email protected]> Co-authored-by: lsun <[email protected]> Co-authored-by: ling <[email protected]> Co-authored-by: Dan Klco <[email protected]> Co-authored-by: Samruddhi <[email protected]> Co-authored-by: Mathieu Lessard <[email protected]> Co-authored-by: Christopher Heintzman <[email protected]>
mathieu-lessard
added a commit
that referenced
this pull request
Mar 15, 2024
* fix: update fstab * Update README.md * ASSETS-3207 integrate Unified shell (#3) * ASSETS-32004 use discovery service to find instances with content hub product profiles (#4) * ASSETS-31822 Create separate security module for Unified Shell * Setup delivery endpoint discovery * docs: update readme * docs: update readme * chore: allow showing 404 page * chore: update sidekick host * chore: remove old comment * fix: update serviceCode===dma_aem_contenthub * fix: don't open browser on "aem up" * ASSETS-32078: Handle changes of imsOrg from Unified Shell * Show spinner while imsOrg changes * fix: use delivery urls from discovery * fix: use delivery urls from discovery * refactor: use page.iframeReload(false); * adapt 404 error page for Unified Shell * feat: reflect url changes from unified shell in app * ASSETS-32075 Hide header bar (logo, user switcher) when using Unified Shell (#5) * ASSETS-32055: POC integration with Upload MFE (#8) * ASSETS-32055: provide bearer token * chore: remove dialog after closing * ASSETS-31831 - Portal style changes for content hub (#6) * chore: fix typo in jsdocs: BrandingConfig.portalTheme * Load Reporting MFE using pure JS * Add css * Add css * Point the reporting MFE to prod * Add discovery call * ASSETS-32176 Keep url in unified shell updated. React to url changes. (#7) Keep url in unified shell updated. React to url changes. handle url changes in asset detail view fix link for link share refactor history listener redirect to /no-access if no delivery env can be found * Accessibility: add role and aria-labels where missing (#10) * quick fix to show reporting in CH * Remove bar graph * fix: cleanup eslint errors * ASSETS-31803 - Refactor Modal code for Unified Shell (#12) * add platform connector * add platform connector with rollup * poc of PlatformConnector * docs: describe rollup * docs: no sudo * cleanup * add PlatformConnector lib * fix: keep existing discovery * cleanup: remove old libs * Update README.md * ASSETS-31899 use PlatfromConnector API for repositoryID * cleanup: only delete dependencies selectively * cleanup: remove unused dependencies * cleanup: undo comment out * cleanup: undo comment out * chore: cleanup imports * PlatformConnector: initial draft (#15) * add platform connector, use rollup to convert library * cleanup after merge * update readme * ASSETS-31899 use franklin lib loadScript based on feedback * ASSETS-31899 add delivery and storageUsage * ASSETS-31831 - Portal changes for content hub (#14) * docs: add sharepoint * fix merge conflicts * ASSETS-31831 - Update style for content hub (#17) * Feat: implement user settings * Feat: implement user settings and redirect users * ASSETS-31899 clear up * Fix modal dialog styling (#18) * ASSETS-31899 remove storageUsage * ASSETS-32522 - Fix upload dialog styling (#19) * add missing import * Feat: Playwright End-2-End test (#11) This is a very simple setup. Expect it to fail for no reason. But it's good to run after making some changes to be sure nothing major broke. * fix: export everything from platform connector * chore: refactor exc-app import/exports * fix: remove text-transform: capitalize; * fix: improve error message when run without unified shell * Fixing to use the IMS org from the site config for GMO * don't call getRepositoryList * Upload dialog (#23) * Fixing to use the distribution url to determine the author repoId * Changing clientid * Adding the version supporting setting metadata * Updating to latest version of the upload MFE * Fixing incorrect mappings * Updating to latest PR build * Updating to new schema * Styling tweaks to the upload dialog * Commented out ProductFamily from 'Add Asset' (#30) * Alphabetize Product List on 'Add Assets' Modal (#32) * DXI-23343: New Multi-required fields. Enable upload on form filled (#34) Co-authored-by: Mathieu Lessard <[email protected]> * DXI-23346: Hydration uses values from Algolia for selections (#35) * DXI-23346: Hydration uses values from Algolia for selections * Adjusted spacing * Adjusted spacing --------- Co-authored-by: Mathieu Lessard <[email protected]> * Updated Asset Upload Experience (#37) * Updated Asset Upload Experience * Added comment regarding why the button change is delayed --------- Co-authored-by: Mathieu Lessard <[email protected]> * Enabled Perpetuity Option * Fixed license date to use ISO instead of epoch * Refactored code * 'Add Assets' button can now be hidden by IMS group (#44) - Added checkAddAssetsAccess() that will compare 'imsAuthorGroup' in 'admin-config.xlsx' in sharepoint to the IMS groups of the current user. - Code that loads the 'Add Assets' button will now not execute unless checkAddAssetsAccess() returns true. * Removed Keywords from Asset Upload * Renamed LisenceDate Property * Renamed LisenceDate Property * Swapped out ims/api key for MarketingHub one --------- Co-authored-by: Aravindo Wingeier <[email protected]> Co-authored-by: Aravindo Wingeier <[email protected]> Co-authored-by: Andrew Khoury <[email protected]> Co-authored-by: Narendra Katamaneni <[email protected]> Co-authored-by: Cris Rockwell <[email protected]> Co-authored-by: lsun <[email protected]> Co-authored-by: ling <[email protected]> Co-authored-by: Dan Klco <[email protected]> Co-authored-by: Samruddhi <[email protected]> Co-authored-by: Mathieu Lessard <[email protected]> Co-authored-by: Christopher Heintzman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: ASSETS-32297
Test URLs: