Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm1100 QFN24 center pad (pin 25) as AVSS #15

Merged
merged 2 commits into from
May 7, 2024

Conversation

jeffc
Copy link
Contributor

@jeffc jeffc commented May 7, 2024

Title:

Add npm1100 QFN24 center pad (pin 25) as AVSS

Description:

According to this devzone answer, the center pad should be connected to AVSS (ground). This is not documented directly in the product specification, only hinted at by the example schematics.

Scope of change:

Schematic (npm1100 QDXX)

Change detail:

  • symbols/nordic-lib-kicad-npm.kicad_sym: Fix incorrect pin mappings

Screenshots:

Before:
image

After:
image

Source of change or fix:

https://devzone.nordicsemi.com/f/nordic-q-a/110896/help-with-strange-npm1100-performance

Testing:

Made a test schematic with this symbol and the associated QFN-24 footprint. Ensured that new connection is established appropriately.

Checklist:

  • [ ✅] My change follows the conventions of the library
  • [ ✅] My changes generate no new warnings

According to
[this devzone answer](https://devzone.nordicsemi.com/f/nordic-q-a/110896/help-with-strange-npm1100-performance),
the center pad should be  connected to AVSS (ground). This is not
documented directly in the product specification, only hinted at by the
example schematics.
@hlord2000
Copy link
Owner

Thanks for the contribution @jeffc

Could you change the pin name to "EP" per KiCAD convention, make it invisible, and stack it w/ the existing AVSS pin? I'm going to go through symbols soon and stack any analog/digital grounds.

Thanks!

@jeffc
Copy link
Contributor Author

jeffc commented May 7, 2024

@hlord2000 I just did the overlap/invisible switch, but I didn't change the name to EP -- the footprint library that this footprint uses (kicad's Package_DFN_QFN) still uses a number (in this case 25) for the center pad. Changing it to EP breaks the symbol <-> footprint association

@hlord2000
Copy link
Owner

@hlord2000 I just did the overlap/invisible switch, but I didn't change the name to EP -- the footprint library that this footprint uses (kicad's Package_DFN_QFN) still uses a number (in this case 25) for the center pad. Changing it to EP breaks the symbol <-> footprint association

The pin name can still be changed to EP. Some other symbols do this, some do not. It's definitely bikeshedding on my part lolol. lgtm and will merge

@hlord2000 hlord2000 merged commit 3c6c90d into hlord2000:main May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants