Updated 3D models for nrf9161,9160,5340 #10
Conversation
Added 3D step files for nrF5340 aQFN94 7 x 7mm SoC and nrf5340 WLSP 4.4 x 4.0mm SoC
Added nrF9161 SiP 3D Model and nrF9160 3D Model extracted from DK hardware and Thingy 91 hardware files
Thank you so much for the PR! I will take a look at it soon! |
Adding in 52833 WLCSP and 52833 aQFN 3D models as well as the 52840 WLCSP 3D model as well. Models from Nordic Example Design Guide Hardware files or DKs
|
Added additional 3D models for nrf52833 and 52840 |
Uploading Nordic nPM 3D models for merge with upstream repo
added in WLCSP models for the nPM1100, nPM1300 and nPM6001 Modules
|
Could you break out these commits into separate PRs? I'm ready to merge the nRF9 commit after a few changes. Basically the names of the 3d models need to be the same as the footprints and the origin of each step file needs to be 0,0,0. |
|
Hi Sure I Will get to it sometime during the week hopefully. Apologies about the file naming convention |
|
@hlord2000 . Sorry I am using Github DeskTop . Is there a quick way to redirect the commits to separate PRs in Desktop?. I have not been able to find a way to do that. My apologies I am quite a new user of Github and have been mainly using the desktop and not the CLI |
No big deal at all! I'll break them out into separate commits. Thanks for the contributions! You can keep pushing to this branch and I'll bring them in. |
|
Hey @hlord2000 just for my own education. Could you let me know how you will break out the commits when you get around to it? I will just like to know the process and also not to make that same error in future commits |
hlord2000
added
bug
Title:
<Updated 3D models for nrf9161,9160,5340,52833,52840>Description:
<3D models of SiPs and SoC's extracted from hardware files used in DK and for 9160 Thingy 91>Scope of change:
<Change is related to 3D models only>Change detail:
File changed #1: <Explain what was changed in this file and why>File changed #2: <Explain what was changed in this file and why>Screenshots:
<If applicable, add screenshots or images to help explain your changes>Source of change or fix:
<Source of 3D models from DK hardware files and Thingy 91 hardware files>Testing:
<No testing performed.>Checklist: