-
Notifications
You must be signed in to change notification settings - Fork 39
Virtualize path and file system operations #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: hkmc2
Are you sure you want to change the base?
Conversation
|
Nice! But please remove all useless whitespace changes from the diff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
However, your changes broke diagnostic reporting.
First, the diagnostics are no longer colored in the console.
Second, they are no longer synchronized. For instance, add a bunch of errors in compilation-test files and watch the output get mangled.
Compare with the previous output:
While the Compiling: and /!!!\ Error messages are not synchronized (would be easy to fix), each error is properly reported separately and not interleaved.
Co-authored-by: Lionel Parreaux <[email protected]>
Co-authored-by: Lionel Parreaux <[email protected]>
Co-authored-by: Lionel Parreaux <[email protected]>
LPTK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it mostly LGTM, but please address these extra commnets and what we discussed by messages.
Co-authored-by: Lionel Parreaux <[email protected]>
Co-authored-by: Lionel Parreaux <[email protected]>
When I make web demos, one of the headaches is that
os.Pathdoesn’t compile when the target is JavaScript. I made a hack on my web demo branch. But the implementation is a bit crappy, especially after merging the latest changes for a few times. Therefore, I want to introduce a path representation and abstract read operations that both supports a real file system or a virtual one (e.g., when the compiler is running on the web).This PR intends to do the following things.
Provide a minimal web demo to showcase the ability to compile multiple files.This will be done in a separate PR.