refactor(26237): Refactor the request infrastructure to the OpenAPI specs #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanch3d
force-pushed
the
epic/23777/bi-directional-frontend
branch
from
6a4233f
to
27b5978
Compare
vanch3d
force-pushed
the
refactor/26237/update-openapi-bi-direct
branch
2 times, most recently
from
a20eb7f
to
00135a9
Compare
vanch3d
force-pushed
the
epic/23777/bi-directional-frontend
branch
from
fa1dd1b
to
17ec687
Compare
…roperly handle mocks
- update mocks - update tests
…E being in the specs
- rename GET hook
- remove old hooks - update mocks
…QTT dev Client - relocate the provider - export the sampling routine to handlers
vanch3d
force-pushed
the
refactor/26237/update-openapi-bi-direct
branch
from
00135a9
to
4f049d1
Compare
h2xd
approved these changes
Sep 27, 2024
| export const deviceHandlers = [ | ||
| http.get('*/protocol-adapters/adapters/:adapterId/tags', ({ params }) => { | ||
| const { adapterId } = params | ||
| console.log('>', { adapterId }) |
There was a problem hiding this comment.
watch out a console that you might not want
| it('should load the data', async () => { | ||
| const { result } = renderHook(() => usePrivateMqttClient(), { wrapper }) | ||
|
|
||
| expect(result.current).toStrictEqual<PrivateMqttClientType>({ state: undefined, actions: undefined }) |
There was a problem hiding this comment.
question: is it right that the data is empty? Does not match the title of the test
Comment on lines
+21
to
+23
| <ConditionalWrapper | ||
| condition={import.meta.env.VITE_FLAG_MOCK_SERVER === 'true'} | ||
| wrapper={(children) => <PrivateMqttClientProvider>{children}</PrivateMqttClientProvider>} |
| @@ -23,6 +24,8 @@ vi.mock('@chakra-ui/react', async () => { | |||
| return { ...actual, useTheme: vi.fn<[], Partial<WithCSSVar<Dict>>>(() => MOCK_THEME) } | |||
| }) | |||
|
|
|||
| //// 44-48,53-63,67-81,86-93 | |||
There was a problem hiding this comment.
question: what does that mean? seems like a debug comment to me
|
Some unit tests seem to fail due to not matching objects, I've added my approval so you can move forward after they are turned green. |
|
Sorry miss clicked on the wrong button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/26237/details/
This PR is part of the bi-directional epic and refactors the query infrastructure to abide to the OpenAPI specs proposed in #563
Design
The current implementation of the bi-directional features in the frontend is still based on a series of mocks (both data and process) to bypass the work-in-progress nature of the backend.
To drive the alignment of the two parts of the engineering process, a proposal was made for the expected API endpoints.
The PR refactors the bespoke mocks into a proper micro-service API mocking
React QueryhooksMSWto intercept the requests and populate the returned bodydev-only and integrated with the relevantMSWhandlersNote that
MSWneeds to be activated for the mocks to be introduced. Change the following environment variable in theenv.localfiles: