-
Notifications
You must be signed in to change notification settings - Fork 36
feat(37055) Add search to the workspace #1213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vanch3d
wants to merge
13
commits into
epic/37055-workspace-operations
Choose a base branch
from
feat/37055-workspace-search
base: epic/37055-workspace-operations
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(37055) Add search to the workspace #1213
vanch3d
wants to merge
13
commits into
epic/37055-workspace-operations
from
feat/37055-workspace-search
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 460 files 460 suites 4m 17s ⏱️ Results for commit 283ced6. ♻️ This comment has been updated with latest results. |
Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://hivemq.kanbanize.com/ctrl_board/57/cards/37055/details/
The PR adds a floating toolbox on the
Workspace
and a long-overdue search tool in it.The search is based on a regex matching on the
id
of every visible (i.e. with thehidden
attribute not set tofalse
) entity (i.e. every node such as adapter, bridge) in the graph.When the search matches a list of existing entities, they are shown as
selected
on the graph, as well as having the viewport centred on the selection.The search string can be cleared, in this case all nodes will be
deselected
and the viewport centred on all the visible nodes (i.e.fitview
)The toolbar also contains two navigation buttons,
prev
andnext
, which allow the users to briefly iterate between each of the individual nodes returned by the matching search pattern. In such navigation, all matching nodes remain selected, but the viewport is now focusing on individual nodes.Please note that the selection used in the search is the same as any manual selection by the users: clicking on another (non-searched) node or on the canvas itself will clear the selection, while keeping the search restrictions
Before
After