Add ServiceMonitor resources for both HiveMQ Platform Operator Helm charts and HiveMQ Platform Helm charts #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afalhambra-hivemq
force-pushed
the
feature/27143-create-service-monitor
branch
3 times, most recently
from
32bf2e7
to
057b37a
Compare
afalhambra-hivemq
force-pushed
the
feature/27143-create-service-monitor
branch
from
057b37a
to
5ddc721
Compare
afalhambra-hivemq
force-pushed
the
feature/27143-create-service-monitor
branch
from
5ddc721
to
cefd455
Compare
Donnerbart
reviewed
Nov 29, 2024
| @@ -349,8 +358,8 @@ tests: | |||
| runAsUser: 185 | |||
| asserts: | |||
| - failedTemplate: | |||
| errorMessage: |- | |||
| `runAsNonRoot` is set to `false` but `runAsUser` is not set to `0` (root) | |||
| errorPattern: |- | |||
There was a problem hiding this comment.
Stupid question: Is there a reason to use |- here? I've seen that you refactored a couple of the errorPattern into a single line and the majority seems to be like that.
There was a problem hiding this comment.
Not a stupid question!
The only reason to use |- is because this unittest plugin does not work when the error message to match starts with some special character like ``` in this case. If you see, the |- is only applied to those starting with such character. It will fail with:
FAIL charts/hivemq-platform-operator/tests/hivemq_operator_deployment_test.yaml
- Execution Error:
yaml: line 362: found character that cannot start any token
Actually, I'm going to raise this an issue on the Helm unittest plugin.
Another option would be to change the error message in our case.
There was a problem hiding this comment.
Donnerbart
reviewed
Nov 29, 2024
mhofsche
approved these changes
Nov 29, 2024
afalhambra-hivemq
force-pushed
the
feature/27143-create-service-monitor
branch
2 times, most recently
from
82562b2
to
6562192
Compare
afalhambra-hivemq
force-pushed
the
feature/27143-create-service-monitor
branch
from
6562192
to
b1b487f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hivemq.kanbanize.com/ctrl_board/22/cards/27143/details/
Edit: Haven't added the new matrix tags to the branch protection rules, as I would like to get first the approval. Will include that and re-trigger the
verifyjob afterwards.