Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance: Add NonValueTransformer Reverse Conversion with NAN_VALUE Replacement #212

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

MooooCat
Copy link
Contributor

Description

Added a new method replace_nan_value within the NonValueTransformer class to handle the replacement of specific "NAN_VALUE" placeholders with empty strings during the reverse conversion process.

This method scans all rows and columns in the DataFrame and performs the replacement, enhancing the usability of the reverse-converted data.

Motivation and Context

This change is required to address the issue of placeholder values ("NAN_VALUE") persisting in the data after reverse conversion, which can lead to inaccuracies and confusion.

By implementing this, we ensure that the data returned after reverse conversion is cleaner and more representative of the original, intended data structure.

How has this been tested?

The new method replace_nan_value has been tested locally with various DataFrame structures and datasets to ensure it correctly identifies and replaces "NAN_VALUE" placeholders across different scenarios.

Additionally, unit tests have been designed to include cases for this new functionality, verifying its integration and impact on the overall reverse conversion process.

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MooooCat MooooCat changed the title add replace_nan_value in NonValueTransformer reverse_convert Enhance: Add NonValueTransformer Reverse Conversion with NAN_VALUE Replacement Jul 31, 2024
@MooooCat MooooCat merged commit 1e2bf67 into main Jul 31, 2024
12 checks passed
@MooooCat MooooCat deleted the enhance-replace-nan_value-in-nan-processor branch July 31, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant