Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHN address inspector #158

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Add CHN address inspector #158

merged 5 commits into from
Mar 11, 2024

Conversation

MooooCat
Copy link
Contributor

Description

This inspector is used to infer whether the columns in the tabular data are of type Address (Mainland China), thereby better labeling the data.

Motivation and Context

How has this been tested?

Types of changes

  • Maintenance (no change in code, maintain the project's CI, docs, etc.)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@MooooCat MooooCat linked an issue Mar 11, 2024 that may be closed by this pull request
@MooooCat MooooCat added this to the 0.2.1 milestone Mar 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.89%. Comparing base (ddd9756) to head (f95adbb).

Files Patch % Lines
sdgx/data_models/inspectors/personal.py 93.75% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   79.82%   79.89%   +0.06%     
==========================================
  Files          69       69              
  Lines        3252     3268      +16     
==========================================
+ Hits         2596     2611      +15     
- Misses        656      657       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MooooCat MooooCat marked this pull request as ready for review March 11, 2024 04:13
@MooooCat MooooCat enabled auto-merge (squash) March 11, 2024 04:27
@MooooCat MooooCat merged commit 52741fd into main Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature | Inspector] add chn address inspector
3 participants