Skip to content

Stretto in-memory backend #111

Stretto in-memory backend

Stretto in-memory backend #111

GitHub Actions / clippy failed Jul 29, 2023 in 1s

clippy

10 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 10
Warning 0
Note 0
Help 0

Versions

  • rustc 1.71.0 (8ede3aae2 2023-07-12)
  • cargo 1.71.0 (cfd3bbd8f 2023-06-08)
  • clippy 0.1.71 (8ede3aa 2023-07-12)

Annotations

Check failure on line 141 in hitbox-backend/src/serializer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

question mark operator is useless here

error: question mark operator is useless here
   --> hitbox-backend/src/serializer.rs:140:9
    |
140 | /         Ok(bincode::serialize(&serializable_value)
141 | |             .map_err(|err| SerializerError::Serialize(Box::new(err)))?)
    | |_______________________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
help: try removing question mark and `Ok()`
    |
140 ~         bincode::serialize(&serializable_value)
141 +             .map_err(|err| SerializerError::Serialize(Box::new(err)))
    |

Check failure on line 127 in hitbox-backend/src/serializer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `T`

error: useless conversion to the same type: `T`
   --> hitbox-backend/src/serializer.rs:127:13
    |
127 |             cached_value.data.into(),
    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cached_value.data`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 107 in hitbox-backend/src/serializer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

question mark operator is useless here

error: question mark operator is useless here
   --> hitbox-backend/src/serializer.rs:106:9
    |
106 | /         Ok(serde_json::to_string(&serializable_value)
107 | |             .map_err(|err| SerializerError::Serialize(Box::new(err)))?)
    | |_______________________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
help: try removing question mark and `Ok()`
    |
106 ~         serde_json::to_string(&serializable_value)
107 +             .map_err(|err| SerializerError::Serialize(Box::new(err)))
    |

Check failure on line 93 in hitbox-backend/src/serializer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `T`

error: useless conversion to the same type: `T`
  --> hitbox-backend/src/serializer.rs:93:13
   |
93 |             cached_value.data.into(),
   |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cached_value.data`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 78 in hitbox-backend/src/serializer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

question mark operator is useless here

error: question mark operator is useless here
  --> hitbox-backend/src/serializer.rs:77:9
   |
77 | /         Ok(serde_json::to_vec(&serializable_value)
78 | |             .map_err(|err| SerializerError::Serialize(Box::new(err)))?)
   | |_______________________________________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
   = note: `-D clippy::needless-question-mark` implied by `-D warnings`
help: try removing question mark and `Ok()`
   |
77 ~         serde_json::to_vec(&serializable_value)
78 +             .map_err(|err| SerializerError::Serialize(Box::new(err)))
   |

Check failure on line 64 in hitbox-backend/src/serializer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `T`

error: useless conversion to the same type: `T`
  --> hitbox-backend/src/serializer.rs:64:13
   |
64 |             cached_value.data.into(),
   |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `cached_value.data`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `-D clippy::useless-conversion` implied by `-D warnings`

Check failure on line 39 in hitbox-backend/src/serializer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

associated function `new` is never used

error: associated function `new` is never used
  --> hitbox-backend/src/serializer.rs:39:12
   |
38 | impl<U> SerializableCachedValue<U> {
   | ---------------------------------- associated function in this implementation
39 |     pub fn new(data: U, expired: DateTime<Utc>) -> Self {
   |            ^^^
   |
   = note: `-D dead-code` implied by `-D warnings`

Check failure on line 67 in hitbox-backend/src/response.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `cached`

error: unused variable: `cached`
  --> hitbox-backend/src/response.rs:67:26
   |
67 |     async fn from_cached(cached: Self::Cached) -> Self {
   |                          ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cached`
   |
   = note: `-D unused-variables` implied by `-D warnings`

Check failure on line 4 in hitbox-backend/src/serializer.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `CachePolicy`, `CacheableResponse`

error: unused imports: `CachePolicy`, `CacheableResponse`
 --> hitbox-backend/src/serializer.rs:4:16
  |
4 |     response::{CachePolicy, CacheableResponse},
  |                ^^^^^^^^^^^  ^^^^^^^^^^^^^^^^^

Check failure on line 5 in hitbox-backend/src/response.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `StreamExt`, `stream`

error: unused imports: `StreamExt`, `stream`
 --> hitbox-backend/src/response.rs:5:15
  |
5 | use futures::{stream, StreamExt};
  |               ^^^^^^  ^^^^^^^^^
  |
  = note: `-D unused-imports` implied by `-D warnings`